| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
|
| |
by default. After this change we need to add
ppp.ingress_filter: true
to npppd.conf if it is needed.
ok sthen
|
| |
|
|
| |
from Michael W. Bombardieri
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compatible equipment provided that the physical interface and other layer 2
devices involved support and are configured to use jumbo frames.
Manpage to follow; typical use is to request 1500 MTU for pppoe, this
requires 1508+ MTU on the physical interface, e.g. "ifconfig em0 mtu 1508;
ifconfig pppoe0 mtu 1500". Known to be usable in the UK with some ISPs
(e.g. aaisp) using BT FTTC backhaul.
From Matt Dainty, originally based on support in NetBSD, changed to
decouple pppoe from physical interface MTU. Tested with UK FTTC by Matt,
no regressions on my standard UK ADSL setup or yasuoka@'s setup (in Japan,
NTT uses 1452 byte MTU for PPPoE and 1500 byte MTU for IPv6 on the same
network).
ok yasuoka@
|
| |
|
|
|
|
| |
Found by LLVM/Clang Static Analyzer.
ok henning@ markus@
|
| |
|
|
|
|
|
|
|
| |
a packet that is passed to the userland has not incremented, `pipex' passed
the packet mistakenly with invalid ack number. Then `npppd' will drop these
packets, so that caused the problem.
tested jmatthew
ok jmatthew
|
| | |
|
| |
|
|
|
|
| |
make their argument list shorter. Also fix a bug where pf_walk_option6()
used the outer header in the pd2 case.
ok henning@ mikeb@
|
| |
|
|
|
|
|
|
|
| |
this prevents backup to failover back to master immediately
after getting link back on carpdev interface if underlying
pfsync interface went down as well. instead pfsync will
request a bulk update to get new states from the master.
sthen and mpf like the idea, ok dlg
|
| |
|
|
|
|
| |
so always show as writable to poll()/select().
Behavior pointed out by Fernando Gont. ok deraadt@
|
| |
|
|
|
|
|
| |
latter is called from pf packet logging. This resulted in normalization
and reassembly of bad packets to be logged. So rearrange the code
and move the call to pf_test().
ok henning@
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reassembly state will be dropped after timeout, all related
fragments are dropped until that. This is conforming to RFC 5722.
- Sort pf_fragment fields while there.
- If the fr_queue is empty, we had overlapping fragments, don't add
new ones.
- If we detect overlapping IPv6 fragments, flush the fr_queue and
drop all fragments immediately.
- Rearrange debug output, to make clear what happens.
- An IPv4 fragment that is totaly overlapped does not inclease the
bad fragment counter.
- Put an KASSERT into pf_isfull_fragment() to make sure that the
fr_queue is never emtpy there.
discussed with Fernando Gont; ok henning@
|
| |
|
|
| |
from Michael W. Bombardieri; ok henning@
|
| |
|
|
| |
ok miod@
|
| |
|
|
|
|
| |
cleaner to access the first member via ia_ifa instead of casting.
No binary change.
ok henning@ krw@
|
| |
|
|
|
|
|
| |
doing more or less the same, merge them into one. Just remove
fragment entries from the queue in pf_join_fragment() before they
are freed. Then pf_remove_fragment() is not needed anymore.
ok henning@
|
| |
|
|
|
| |
in pf_test_state_*(). This needs less code and is more consistent.
OK mikeb, markus, henning.
|
| |
|
|
| |
also don't do af translation if pf_translate didn't succeed. ok henning
|
| |
|
|
|
|
|
| |
(there only one state and it's direction is always PF_IN) and don't
exclude icmp echo replies from the test.
ok mcbride, claudio on previous version, ok henning, "looks good" deraadt
|
| |
|
|
|
|
|
|
|
|
| |
pfctl should not infer the af-to behavior from the af/naf difference.
instead, we should be clear that this is an af-to rule. essentially
this change converts FOM_AFTO marker into a rule flag PFRULE_AFTO so
that we don't rely on ambiguous checks (like r->af != r->naf) when
setting things up.
positive review and comments from claudio, ok henning, sperreault
|
| |
|
|
|
| |
testing sthen@
ok sthen@ henning@ dlg@
|
| |
|
|
|
| |
testing sthen@
ok sthen@ henning@ dlg@
|
| |
|
|
|
| |
testing sthen@
ok sthen@ henning@ dlg@
|
| |
|
|
| |
ok claudio@ henning@ mikeb@
|
| |
|
|
| |
ok dlg claudio
|
| |
|
|
|
|
|
|
|
|
|
|
| |
with every other thing that stores the state id (including other pfsync
messages).
includes improvements to the systat code to consider the creatorid as well
as the state id in its cache to avoid collisions between states created on
different hosts.
tested by me in production and on amd64 talking to sparc64.
ok henning@
|
| |
|
|
|
|
|
| |
pf_state_expires() handled it incorrectly.
discussed with mikeb@
ok henning@
|
| |
|
|
| |
accidental race conditions. From Erik Lax, thanks! ok dlg
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
When transmitting through vlan(4), it will now use the prio value in
pf packet header. When receiving, we save the incoming Cos in the same
place, this gives us the hability to preserve the CoS value across two
different vlan interfaces.
This kills the SIOC[GS]VLANPRIO ioctls and removes the corresponding
buttons from ifconfig(8).
ok henning@ claudio@ mcbride@
|
| |
|
|
|
|
| |
connection does not observe the route-to option.
ok dlg mikeb
|
| |
|
|
|
| |
pointed out by Julien Crapovich on misc@
ok deraadt mikeb
|
| |
|
|
|
|
|
| |
skewed at runtime by things like date(1) and ntpd. time_uptime is
monotonic and therefore more useful to compare against.
ok deraadt@ mikeb@
|
| |
|
|
|
|
|
|
| |
only when we're going up, not when we set PROMISC or any other
flag. Fixes spontaneous CARP failovers when running tcpdump
on pfsync.
ok henning, mcbride, camield
|
| |
|
|
| |
From Abel Abraham Camarillo Ojeda, reminded by Brad.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calculations, and does _not_ denote the time when to expire. So
it should never be added to (set into the future).
Try to reconstruct it with an educated guess on state import and
just set it to the current time on state updates.
This fixes a problem on pfsync listeners where the expiry time
could be double the expected value and cause a lot more states
to linger.
Timeout code from mikeb.
Found and testing by Maxim Bourmistrov.
ok mikeb dlg
|
| |
|
|
| |
an icmp<->icmp6 state (nat64); ok henning, mcbride, dlg
|
| |
|
|
|
|
|
|
|
| |
device hardware features.
Tune ifconfig to show them with 'hwfeatures' argument.
While here, kill some old unused capabilities and respect 80 columns
in brconfig.h.
ok mcbride@, henning@, mpf@.
|
| |
|
|
| |
interface. Problem report and fix from Erik Lax, thanks!
|
| |
|
|
|
| |
than the syncdev MTU. Prompted by the discussion with and tested
by Maxim Bourmistrov; ok dlg, mpf
|
| |
|
|
|
|
|
|
|
|
| |
tr_linkstate() was not initialized in trunk_rr_attach(), and
tr_init() and tr_stop() were missing in trunk_lb_attach().
Fixes crash triggered by changing trunkproto, reported by Anders
Berggren on bugs@.
ok mpf henning
|
| |
|
|
| |
by pedro/gcc.
|
| |
|
|
|
|
|
| |
if_detach() handles this ok. carpdetach() can now lower the demote
count on the carp group correctly.
ok henning mpf
|
| |
|
|
|
|
|
|
| |
on mbuf chains of insufficient length; prevents crashes seen by
dhill. also bring in some chunks omitted in the nat64 commit and
are essential for correct packet interpretation.
tested by dhill and me, ok henning
|
| | |
|
| |
|
|
| |
mcbride agrees, ok mpf, dlg
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reorder packets to pass to the upper layer without reorder. It
will improve performance (throughput or loss rate) for PPTP or
L2TP(/IPesc) on networks that latency is unstable such as mobile
network.
As our test environment (bandwidth: 6Mbps, latency: 50ms for 97% of
traffic and 52ms for rest of traffic), throughput has changed from
0.76MB to 2.17MB on file upload by PPTP connected Windows Vista
ftp.exe.
Developed by UMEZAWA Takeshi at IIJ.
ok jmatthew@
tested jmatthew@ and myself.
|
| |
|
|
|
|
|
|
| |
"af-to" a generic IP version translator for pf(4).
Not everything perfect yet but lets fix these things in the tree.
Insane amount of work done by sperreault@, mikeb@ and reyk@.
Looked over by mcbride@ henning@ and myself at eurobsdcon.
OK mcbride@ and general put it in from deraadt@
|
| |
|
|
|
|
| |
unfortunately altq is one giant namespace violation. rename just those that
conflict with new stuff for now only to be found on my laptop. reduce pain,
the diff is huge already. ok ryan
|
| |
|
|
| |
just one and the variable name is clear enough. ryan ok
|
| | |
|