| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@
|
|
|
|
|
|
|
|
|
|
|
| |
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.
This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@
|
|
|
|
| |
explicitly; ok millert@
|
|
|
|
|
|
| |
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@
|
|
|
|
|
|
|
|
|
|
| |
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@
|
| |
|
| |
|
|
|
|
|
| |
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown
|
|
|
|
|
| |
to just be 0/1
ok miod florian
|
|
|
|
|
| |
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.
|
|
|
|
| |
Debug message consistency: format opts with %#x and modes with %#04o
|
|
|
|
|
|
|
|
|
| |
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit
|
|
|
|
|
|
|
|
|
| |
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)
|
|
|
|
| |
Fix from Dennis Lindroos (denafcm (at) gmail.com)
|
| |
|
| |
|
| |
|
|
|
|
| |
wrappers
|
| |
|
|
|
|
| |
Kill some 'notyet' code that will never be enabled
|
|
|
|
| |
Assume we have rcmdsh()
|
|
|
|
| |
Add parens to quiet gcc on previous commit
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.
ok deraadt@
|
| |
|
|
|
|
|
|
| |
Enable warnings.
ok krw@, ian@
|
|
|
|
|
|
|
| |
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.
ok deraadt@
|
|
|
|
|
|
|
| |
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms
|
|
|
|
|
| |
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen
|
| |
|
|
|
|
|
| |
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@
|
|
|
|
|
|
| |
Improve error checking.
OK okan@
|
| |
|
| |
|
| |
|
|
|
|
| |
millert@ ok
|
|
|
|
| |
rescinded 22 July 1999. Proofed by myself and Theo.
|
|
|
|
|
|
|
| |
o KNF and ANSIfy the function headers
Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
millert@ ok
|
|
|
|
|
|
|
| |
idea from deraadt@ via NetBSD
millert@ ok
p.s. Next commit will fix a typo in the sys/
|
|
|
|
| |
Remove a useless loop invariant (already tested before the loop is reached).
|