Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fix use-after-free in ssh-pkcs11; found by hshoexer w/AFL | 2019-03-08 | 1 | -1/+3 | |
| | |||||
* | fix NULL-deref crash in PKCS#11 code when attempting login to a token | 2019-02-04 | 1 | -2/+17 | |
| | | | | requiring a PIN; reported by benno@ fix mostly by markus@ | ||||
* | Correct some bugs in PKCS#11 token PIN handling at initial login, | 2019-01-22 | 1 | -12/+22 | |
| | | | | | | | the attempt at reading the PIN could be skipped in some cases especially on devices with integrated PIN readers. based on patch from Daniel Kucera in bz#2652; ok markus@ | ||||
* | Support keys that set the CKA_ALWAYS_AUTHENTICATE by requring a | 2019-01-22 | 1 | -26/+95 | |
| | | | | | | fresh login after the C_SignInit operation. based on patch from Jakub Jelen in bz#2638; ok markus | ||||
* | always print the caller's error message in ossl_error(), even when there | 2019-01-21 | 1 | -2/+3 | |
| | | | | are no libcrypto errors to report. | ||||
* | get the ex_data (pkcs11_key object) back from the keys at the | 2019-01-21 | 1 | -9/+8 | |
| | | | | index at which it was inserted, rather than assuming index 0 | ||||
* | use ECDSA_SIG_set0() instead of poking signature values into | 2019-01-21 | 1 | -3/+14 | |
| | | | | | structure directly; the latter works on LibreSSL but not on OpenSSL. From portable. | ||||
* | we use singleton pkcs#11 RSA_METHOD and EC_KEY_METHOD now, so there | 2019-01-20 | 1 | -7/+3 | |
| | | | | | | is no need to keep a copy of each in the pkcs11_key object. work by markus@, ok djm@ | ||||
* | KNF previous; from markus@ | 2019-01-20 | 1 | -6/+6 | |
| | |||||
* | use OpenSSL's RSA reference counting hooks to implicitly clean up | 2019-01-20 | 1 | -35/+21 | |
| | | | | | | | | pkcs11_key objects when their owning RSA object's reference count drops to zero. Simplifies the cleanup path and makes it more like ECDSA's work by markus@, ok djm@ | ||||
* | make the PKCS#11 RSA code more like the new PKCS#11 ECDSA code: | 2019-01-20 | 1 | -16/+29 | |
| | | | | | | | use a single custom RSA_METHOD instead of a method per key suggested by me, but markus@ did all the work. ok djm@ | ||||
* | fix leak of ECDSA pkcs11_key objects | 2019-01-20 | 1 | -2/+21 | |
| | | | | work by markus, ok djm@ | ||||
* | use EVP_PKEY_get0_EC_KEY() instead of direct access of EC_KEY internals | 2019-01-20 | 1 | -4/+3 | |
| | | | | | | as that won't work on OpenSSL work by markus@, feedback and ok djm@ | ||||
* | cleanup PKCS#11 ECDSA pubkey loading: the returned object should never | 2019-01-20 | 1 | -10/+14 | |
| | | | | | | have a DER header work by markus; feedback and ok djm@ | ||||
* | cleanup unnecessary code in ECDSA pkcs#11 signature support: the | 2019-01-20 | 1 | -25/+16 | |
| | | | | | | sign operation does not return DER, but a concatenation of r|s work by markus@, feedback and ok djm@ | ||||
* | add support for ECDSA keys in PKCS#11 tokens | 2019-01-20 | 1 | -204/+1149 | |
| | | | | Work by markus@ and Pedro Martelletto, feedback and ok me@ | ||||
* | hold our collective noses and use the openssl-1.1.x API in OpenSSH; | 2018-09-13 | 1 | -16/+41 | |
| | | | | feedback and ok tb@ jsing@ markus@ | ||||
* | Remove all guards for calls to OpenSSL free functions - all of these | 2018-02-07 | 1 | -3/+2 | |
| | | | | | | | | | functions handle NULL, from at least OpenSSL 1.0.1g onwards. Prompted by dtucker@ asking about guards for RSA_free(), when looking at openssh-portable pr#84 on github. ok deraadt@ dtucker@ | ||||
* | Switch to recallocarray() for a few operations. Both growth and shrinkage | 2017-05-31 | 1 | -3/+3 | |
| | | | | | | are handled safely, and there also is no need for preallocation dances. Future changes in this area will be less error prone. Review and one bug found by markus | ||||
* | sshkey_new() might return NULL (pkcs#11 code only); ok djm@ | 2017-05-30 | 1 | -2/+3 | |
| | |||||
* | Improve pkcs11_add_provider() logging: demote some excessively | 2016-10-28 | 1 | -15/+26 | |
| | | | | | | verbose error()s to debug()s, include PKCS#11 provider name and slot in log messages where possible. bz#2610, based on patch from Jakub Jelen | ||||
* | avoid fatal() for PKCS11 tokens that present empty key IDs | 2016-02-12 | 1 | -3/+5 | |
| | | | | bz#1773, ok markus@ | ||||
* | don't ignore PKCS#11 hosted keys that return empty CKA_ID; | 2015-07-18 | 1 | -6/+14 | |
| | | | | patch by Jakub Jelen via bz#2429; ok markus | ||||
* | skip uninitialised PKCS#11 slots; patch from Jakub Jelen in bz#2427 | 2015-07-18 | 1 | -1/+6 | |
| | | | | ok markus@ | ||||
* | support PKCS#11 devices with external PIN entry devices | 2015-05-27 | 1 | -12/+20 | |
| | | | | | bz#2240, based on patch from Dirk-Willem van Gulik; feedback and ok dtucker@ | ||||
* | rename xrealloc() to xreallocarray() since it follows that form. | 2015-04-24 | 1 | -2/+2 | |
| | | | | ok djm | ||||
* | missing ; | 2015-02-03 | 1 | -2/+2 | |
| | | | | djm and mlarkin really having great interactions recently | ||||
* | handle PKCS#11 C_Login returning CKR_USER_ALREADY_LOGGED_IN; | 2015-02-02 | 1 | -5/+7 | |
| | | | | based on patch from Yuri Samoilenko; ok markus@ | ||||
* | sync ssh-keysign, ssh-keygen and some dependencies to the new | 2015-01-15 | 1 | -13/+13 | |
| | | | | buffer/key API; mostly mechanical, ok markus@ | ||||
* | New key API: refactor key-related functions to be more library-like, | 2014-06-24 | 1 | -2/+2 | |
| | | | | | | | | | existing API is offered as a set of wrappers. with and ok markus@ Thanks also to Ben Hawkes, David Tomaschik, Ivan Fratric, Matthew Dempsky and Ron Bowes for a detailed review a few months ago. | ||||
* | revert __bounded change; it causes way more problems for portable than | 2014-05-02 | 1 | -2/+2 | |
| | | | | it solves; pointed out by dtucker@ | ||||
* | use __bounded(...) attribute recently added to sys/cdefs.h instead of | 2014-03-26 | 1 | -2/+2 | |
| | | | | | | longform __attribute__(__bounded(...)); for brevity and a warning free compilation with llvm/clan | ||||
* | add missing braces found by pedro | 2013-11-13 | 1 | -2/+2 | |
| | |||||
* | from portable: s/true/true_val/ to avoid name collisions on dump platforms | 2013-11-06 | 1 | -3/+3 | |
| | |||||
* | support pkcs#11 tokes that only provide x509 zerts instead of raw pubkeys; | 2013-11-02 | 1 | -28/+98 | |
| | | | | fixes bz#1908; based on patch from Laurent Barbe; ok djm | ||||
* | fix pointer-signedness warnings from clang/llvm-3.3; "seems nice" deraadt@ | 2013-07-12 | 1 | -6/+6 | |
| | |||||
* | bye, bye xfree(); ok markus@ | 2013-05-17 | 1 | -15/+12 | |
| | |||||
* | check length of value returned C_GetAttributValue for != 0 | 2010-06-08 | 1 | -2/+8 | |
| | | | | from mdrtbugzilla@codefive.co.uk; bugzilla #1773; ok dtucker@ | ||||
* | retry lookup for private key if there's no matching key with CKA_SIGN | 2010-04-15 | 1 | -11/+34 | |
| | | | | | attribute enabled; this fixes fixes MuscleCard support (bugzilla #1736) ok djm@ | ||||
* | Add $OpenBSD$ tags in comments, our portable-syncing scripts use these | 2010-02-24 | 1 | -0/+1 | |
| | |||||
* | dlclose() call should also be #ifdef HAVE_DLOPEN | 2010-02-21 | 1 | -0/+2 | |
| | |||||
* | unbreak build for NOPIC systems; noticed, help and ok deraadt@ | 2010-02-20 | 1 | -0/+9 | |
| | |||||
* | replace our obsolete smartcard code with PKCS#11. | 2010-02-08 | 1 | -0/+544 | |
ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-11/v2-20/pkcs-11v2-20.pdf ssh(1) and ssh-keygen(1) use dlopen(3) directly to talk to a PKCS#11 provider (shared library) while ssh-agent(1) delegates PKCS#11 to a forked a ssh-pkcs11-helper process. PKCS#11 is currently a compile time option. feedback and ok djm@; inspired by patches from Alon Bar-Lev |