| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
| |
previously disabled it because we were reading to fast (from disk).
Problem noted and tracked down to that commit by weerd@ and
independently by stsp@.
Tested by weerd@, stsp@, reyk@
OK bluhm@, reyk@
|
| |
|
|
|
|
| |
we need more care to find a proper fix for the fastcgi headers.
acknowledged by deraadt@
|
| |
|
|
|
|
| |
parse it. Otherwise http headers can leak into the body.
Pointed out by Jean-Philippe Ouellet on bugs@ Thanks!
OK reyk, commit ASAP deraadt@
|
| |
|
|
|
|
|
|
|
|
| |
SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER by default. This gives
tls_write() a similar short write semantics as write(2) and a
workaround in httpd to cope with the previous differences can be
removed. Specifically, httpd can stop copying data into a local
buffer that was used to keep it around for repeated writes.
OK bluhm@
|
| |
|
|
|
|
|
|
|
|
| |
reading from disk when we hold a certain amount of data in
RAM. Re-enable reading once we send enough data to the
client. Otherwise we might end up with the whole file (which can be
huge) in RAM.
Reported by Matthew Martin ( matt.a.martin AT gmail ) on bugs@,
thanks!
OK reyk@, benno@
|
| |
|
|
| |
OK benno@
|
| |
|
|
|
|
| |
Based on a diff from Jack Burton <jack at saosce dot com dot au>.
ok reyk@
|
| | |
|
| |
|
|
|
|
|
|
|
| |
including them in the IMSG_CFG_SERVER imsg. This allows the certificate
and key to each be almost 16KB (the maximum size for an imsg), rather than
having a combined total of less than 16KB (which can be reached with large
keys, certificate bundles or by including text versions of certificates).
ok reyk@
|
| |
|
|
| |
ok reyk@
|
| |
|
|
|
|
|
|
|
|
| |
config.c r1.34 and r1.30 introduced potential memory leaks for auth and
return_uri when config_getserver fails. Fix this by switching to
serverconfig_free() and adding the missing free for srv_conf->auth.
While here, make serverconfig_free() a little more bulletproof by
explicit_bzero()ing key material.
ok reyk@
|
| |
|
|
|
|
|
| |
clt_log evbuffer.
server_close() calls server_log() which uses ctl_log.
Crash reported by Daniel Jakots <vigdis AT chown DOT me>, thanks!
OK benno
|
| |
|
|
|
|
|
|
|
| |
appropriately. Otherwise imsg construction can silently fail, resulting in
non-obvious problems.
Found the hard way by Theodore Wynnychenko.
ok doug@ florian@
|
| |
|
|
|
|
|
|
| |
While here unconditionally free clt and move declaration of
server_inflight_dec() into server.c
Found while investigating if (foo != NULL) free(foo) patterns pointed
out by Markus Elfring.
OK reyk
|
| |
|
|
|
|
| |
imsg buffer.
Debugging & OK halex@
|
| |
|
|
|
|
| |
option.
ok reyk@
|
| |
|
|
|
|
|
|
| |
that includes all currently supported protocols (TLSv1.0, TLSv1.1 and
TLSv1.2). Change all users of libtls to use TLS_PROTOCOLS_ALL so that they
maintain existing behaviour.
Discussed with tedu@ and reyk@.
|
| | |
|
| |
|
|
|
|
|
| |
parameters and the ECDHE curve. This primarily allows for DHE cipher suites
to be enabled.
ok reyk@
|
| |
|
|
| |
OK florian@
|
| |
|
|
|
|
|
|
|
| |
needed by its ancestor. jsg@, include-what-you-use, and some manual
review helped to cleanup the headers (take iwyu with a grain of salt).
Based on common practice, httpd.h now also includes the necessary
headers for itself.
OK florian@
|
| |
|
|
| |
OK florian@
|
| |
|
|
|
|
|
|
|
| |
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)
|
| | |
|
| |
|
|
|
|
|
| |
prevents running out of file descriptors when loading a configuration
with many aliases.
OK florian@
|
| |
|
|
|
|
| |
*Do* pull it in when in_{port,addr}_h is needed and <netinet/in.h> isn't.
ok reyk@
|
| |
|
|
|
|
| |
reflect reality.
OK benno@
|
| |
|
|
| |
from Max Fillinger
|
| | |
|
| |
|
|
| |
ok millert@
|
| |
|
|
| |
ok tedu@
|
| |
|
|
|
|
|
| |
loop that could eat all CPU. I thought that the previous (correct)
commit fixed it which wasn't the case. But this one is obvious.
ok florian@
|
| |
|
|
|
|
|
|
|
| |
The key has been changed to server name + address + port and now it is
possible to use the same server name for multiple servers with
different addresses, eg. http://www.example.com and
https://www.example.com/.
OK doug@ florian@
|
| |
|
|
|
|
|
|
|
| |
for persistent connections with FastCGI by implementing chunked
Transfer-Encoding. This only works with HTTP/1.1.
With input and help from florian@ who found some FastCGI edge cases.
OK florian@
|
| |
|
|
|
|
|
| |
is not empty. This fixes a bug of short responses that could happen
with large files or fcgi data on connections with a higher latency.
OK florian@
|
| |
|
|
| |
Pointed out by deraadt@
|
| |
|
|
| |
ok deraadt@ reyk@
|
| |
|
|
| |
ok deraadt@ reyk@
|
| |
|
|
| |
with & OK reyk@
|
| | |
|
| |
|
|
|
|
|
| |
support. Instead of calling server_close from server_write, we have
to proceed to the next connection by calling the error handler.
OK jsg@
|
| |
|
|
| |
"done" to simplify connection debugging.
|
| |
|
|
|
|
|
|
|
| |
This fixes sending of large files. Previously, httpd was reading the
input file too quickly and could run out of memory when filling the
input buffer.
Found by jsg@
OK florian@
|
| |
|
|
| |
ok deraadt@ guenther@
|
| |
|
|
|
|
|
| |
to the privsep process via imsg. This allows the keys to be moved out of
the chroot (now /etc/ssl/server.crt, /etc/ssl/private/server.key).
ok reyk@
|
| |
|
|
|
|
|
| |
files can also be owned by root now: they're opened by the parent and
send to the logger process with fd passing. This also works with reload.
ok deraadt@
|
| |
|
|
|
|
|
| |
certificate from /var/www/ to /var/www/conf/. Don't get scared - this
will be changed soon! They're currently located in the chroot
directory but will be moved outside as soon as we adopted some of the
key privsep from relayd in ressl/httpd.
|
| |
|
|
|
|
|
| |
"Add TLS/SSL support to httpd, based on the recent ressl commits."
From jsing@
ok reyk@
|
| |
|
|
|
|
| |
syslog is still supported but disabled by default.
ok deraadt@
|
| |
|
|
| |
The secrect plan is to add it later using the ressl wrapper library.
|