manager: do not raise error if manager service is already starting

If the service is in StartPending state, then it means that we were
*just* started by something else, so return success here, assuming the
other program starting this does the right thing. This can happen when,
e.g., the updater relaunches the manager service and then invokes
wireguard.exe to raise the UI.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

1 files changed, 6 insertions, 0 deletions

diff --git a/manager/install.go b/manager/install.go
index 3983de1d..f1937d0a 100644
--- a/manager/install.go
+++ b/manager/install.go
@@ -56,6 +56,12 @@ func InstallManager() error {
 		}
 		if status.State != svc.Stopped {
 			service.Close()
+			if status.State == svc.StartPending {
+				// We were *just* started by something else, so return success here, assuming the other program
+				// starting this does the right thing. This can happen when, e.g., the updater relaunches the
+				// manager service and then invokes wireguard.exe to raise the UI.
+				return nil
+			}
 			return ErrManagerAlreadyRunning
 		}
 		err = service.Delete()