diff options
| author |   Jason A. Donenfeld <Jason@zx2c4.com> | 2019-06-06 15:44:29 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2019-06-07 11:31:53 +0200 |
| commit | 6f9a7593646c6af0d4f19af2f669ce28b6e30cab (patch) | |
| tree | dd1e16a34fafff9635381e21e99c65421ed5cbf4 /updater/msirunner_windows.go | |
| parent | tunnel: perform full stop on shutdown (diff) | |
| download | wireguard-windows-6f9a7593646c6af0d4f19af2f669ce28b6e30cab.tar.xz wireguard-windows-6f9a7593646c6af0d4f19af2f669ce28b6e30cab.zip | |
global: cleanup TODO comment spacing
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'updater/msirunner_windows.go')
| -rw-r--r-- | updater/msirunner_windows.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/updater/msirunner_windows.go b/updater/msirunner_windows.go index 84ddde28..62ec1cdf 100644 --- a/updater/msirunner_windows.go +++ b/updater/msirunner_windows.go @@ -69,11 +69,11 @@ func msiTempFile() (*os.File, error) { Length: uint32(len(sd)), SecurityDescriptor: uintptr(unsafe.Pointer(&sd[0])), } - //TODO: os.TempDir() returns C:\windows\temp when calling from this context. Supposedly this is mostly secure + // TODO: os.TempDir() returns C:\windows\temp when calling from this context. Supposedly this is mostly secure // against TOCTOU, but who knows! Look into this! name := filepath.Join(os.TempDir(), hex.EncodeToString(randBytes[:])) name16 := windows.StringToUTF16Ptr(name) - //TODO: it would be nice to specify delete_on_close, but msiexec.exe doesn't open its files with read sharing. + // TODO: it would be nice to specify delete_on_close, but msiexec.exe doesn't open its files with read sharing. fileHandle, err := windows.CreateFile(name16, windows.GENERIC_WRITE, windows.FILE_SHARE_READ, sa, windows.CREATE_NEW, windows.FILE_ATTRIBUTE_NORMAL, 0) runtime.KeepAlive(sd) if err != nil { |