diff options
Diffstat (limited to 'conf/dpapi')
-rw-r--r-- | conf/dpapi/dpapi_windows.go | 73 | ||||
-rw-r--r-- | conf/dpapi/dpapi_windows_test.go | 8 | ||||
-rw-r--r-- | conf/dpapi/mksyscall.go | 8 | ||||
-rw-r--r-- | conf/dpapi/zdpapi_windows.go | 68 |
4 files changed, 22 insertions, 135 deletions
diff --git a/conf/dpapi/dpapi_windows.go b/conf/dpapi/dpapi_windows.go index 851ec1ee..49a32915 100644 --- a/conf/dpapi/dpapi_windows.go +++ b/conf/dpapi/dpapi_windows.go @@ -1,86 +1,53 @@ /* SPDX-License-Identifier: MIT * - * Copyright (C) 2019 WireGuard LLC. All Rights Reserved. + * Copyright (C) 2019-2022 WireGuard LLC. All Rights Reserved. */ package dpapi import ( "errors" + "fmt" "runtime" "unsafe" "golang.org/x/sys/windows" ) -const ( - dpCRYPTPROTECT_UI_FORBIDDEN uint32 = 0x1 - dpCRYPTPROTECT_LOCAL_MACHINE uint32 = 0x4 - dpCRYPTPROTECT_CRED_SYNC uint32 = 0x8 - dpCRYPTPROTECT_AUDIT uint32 = 0x10 - dpCRYPTPROTECT_NO_RECOVERY uint32 = 0x20 - dpCRYPTPROTECT_VERIFY_PROTECTION uint32 = 0x40 - dpCRYPTPROTECT_CRED_REGENERATE uint32 = 0x80 -) - -type dpBlob struct { - len uint32 - data uintptr -} - -func bytesToBlob(bytes []byte) *dpBlob { - blob := &dpBlob{} - blob.len = uint32(len(bytes)) +func bytesToBlob(bytes []byte) *windows.DataBlob { + blob := &windows.DataBlob{Size: uint32(len(bytes))} if len(bytes) > 0 { - blob.data = uintptr(unsafe.Pointer(&bytes[0])) + blob.Data = &bytes[0] } return blob } -//sys cryptProtectData(dataIn *dpBlob, name *uint16, optionalEntropy *dpBlob, reserved uintptr, promptStruct uintptr, flags uint32, dataOut *dpBlob) (err error) = crypt32.CryptProtectData - func Encrypt(data []byte, name string) ([]byte, error) { - out := dpBlob{} - err := cryptProtectData(bytesToBlob(data), windows.StringToUTF16Ptr(name), nil, 0, 0, dpCRYPTPROTECT_UI_FORBIDDEN, &out) + out := windows.DataBlob{} + err := windows.CryptProtectData(bytesToBlob(data), windows.StringToUTF16Ptr(name), nil, 0, nil, windows.CRYPTPROTECT_UI_FORBIDDEN, &out) if err != nil { - return nil, errors.New("Unable to encrypt DPAPI protected data: " + err.Error()) + return nil, fmt.Errorf("unable to encrypt DPAPI protected data: %w", err) } - - outSlice := *(*[]byte)(unsafe.Pointer(&(struct { - addr uintptr - len int - cap int - }{out.data, int(out.len), int(out.len)}))) - ret := make([]byte, len(outSlice)) - copy(ret, outSlice) - windows.LocalFree(windows.Handle(out.data)) - + ret := make([]byte, out.Size) + copy(ret, unsafe.Slice(out.Data, out.Size)) + windows.LocalFree(windows.Handle(unsafe.Pointer(out.Data))) return ret, nil } -//sys cryptUnprotectData(dataIn *dpBlob, name **uint16, optionalEntropy *dpBlob, reserved uintptr, promptStruct uintptr, flags uint32, dataOut *dpBlob) (err error) = crypt32.CryptUnprotectData - func Decrypt(data []byte, name string) ([]byte, error) { - out := dpBlob{} + out := windows.DataBlob{} var outName *uint16 utf16Name, err := windows.UTF16PtrFromString(name) if err != nil { return nil, err } - - err = cryptUnprotectData(bytesToBlob(data), &outName, nil, 0, 0, dpCRYPTPROTECT_UI_FORBIDDEN, &out) + err = windows.CryptUnprotectData(bytesToBlob(data), &outName, nil, 0, nil, windows.CRYPTPROTECT_UI_FORBIDDEN, &out) if err != nil { - return nil, errors.New("Unable to decrypt DPAPI protected data: " + err.Error()) + return nil, fmt.Errorf("unable to decrypt DPAPI protected data: %w", err) } - - outSlice := *(*[]byte)(unsafe.Pointer(&(struct { - addr uintptr - len int - cap int - }{out.data, int(out.len), int(out.len)}))) - ret := make([]byte, len(outSlice)) - copy(ret, outSlice) - windows.LocalFree(windows.Handle(out.data)) + ret := make([]byte, out.Size) + copy(ret, unsafe.Slice(out.Data, out.Size)) + windows.LocalFree(windows.Handle(unsafe.Pointer(out.Data))) // Note: this ridiculous open-coded strcmp is not constant time. different := false @@ -94,14 +61,14 @@ func Decrypt(data []byte, name string) ([]byte, error) { if *a == 0 || *b == 0 { break } - a = (*uint16)(unsafe.Pointer(uintptr(unsafe.Pointer(a)) + 2)) - b = (*uint16)(unsafe.Pointer(uintptr(unsafe.Pointer(b)) + 2)) + a = (*uint16)(unsafe.Add(unsafe.Pointer(a), 2)) + b = (*uint16)(unsafe.Add(unsafe.Pointer(b), 2)) } runtime.KeepAlive(utf16Name) windows.LocalFree(windows.Handle(unsafe.Pointer(outName))) if different { - return nil, errors.New("The input name does not match the stored name") + return nil, errors.New("input name does not match the stored name") } return ret, nil diff --git a/conf/dpapi/dpapi_windows_test.go b/conf/dpapi/dpapi_windows_test.go index 8356f2d4..fd7307e6 100644 --- a/conf/dpapi/dpapi_windows_test.go +++ b/conf/dpapi/dpapi_windows_test.go @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: MIT * - * Copyright (C) 2019 WireGuard LLC. All Rights Reserved. + * Copyright (C) 2019-2022 WireGuard LLC. All Rights Reserved. */ package dpapi @@ -53,11 +53,7 @@ func TestRoundTrip(t *testing.T) { if err != nil { t.Errorf("Unable to get utf16 chars for name: %s", err) } - nameUtf16Bytes := *(*[]byte)(unsafe.Pointer(&struct { - addr *byte - len int - cap int - }{(*byte)(unsafe.Pointer(&nameUtf16[0])), len(nameUtf16) * 2, cap(nameUtf16) * 2})) + nameUtf16Bytes := unsafe.Slice((*byte)(unsafe.Pointer(&nameUtf16[0])), len(nameUtf16)*2) i := bytes.Index(eCorrupt, nameUtf16Bytes) if i == -1 { t.Error("Unable to find ad in blob") diff --git a/conf/dpapi/mksyscall.go b/conf/dpapi/mksyscall.go deleted file mode 100644 index 3d467f76..00000000 --- a/conf/dpapi/mksyscall.go +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: MIT - * - * Copyright (C) 2019 WireGuard LLC. All Rights Reserved. - */ - -package dpapi - -//go:generate go run golang.org/x/sys/windows/mkwinsyscall -output zdpapi_windows.go dpapi_windows.go diff --git a/conf/dpapi/zdpapi_windows.go b/conf/dpapi/zdpapi_windows.go deleted file mode 100644 index e48d36b2..00000000 --- a/conf/dpapi/zdpapi_windows.go +++ /dev/null @@ -1,68 +0,0 @@ -// Code generated by 'go generate'; DO NOT EDIT. - -package dpapi - -import ( - "syscall" - "unsafe" - - "golang.org/x/sys/windows" -) - -var _ unsafe.Pointer - -// Do the interface allocations only once for common -// Errno values. -const ( - errnoERROR_IO_PENDING = 997 -) - -var ( - errERROR_IO_PENDING error = syscall.Errno(errnoERROR_IO_PENDING) -) - -// errnoErr returns common boxed Errno values, to prevent -// allocations at runtime. -func errnoErr(e syscall.Errno) error { - switch e { - case 0: - return nil - case errnoERROR_IO_PENDING: - return errERROR_IO_PENDING - } - // TODO: add more here, after collecting data on the common - // error values see on Windows. (perhaps when running - // all.bat?) - return e -} - -var ( - modcrypt32 = windows.NewLazySystemDLL("crypt32.dll") - - procCryptProtectData = modcrypt32.NewProc("CryptProtectData") - procCryptUnprotectData = modcrypt32.NewProc("CryptUnprotectData") -) - -func cryptProtectData(dataIn *dpBlob, name *uint16, optionalEntropy *dpBlob, reserved uintptr, promptStruct uintptr, flags uint32, dataOut *dpBlob) (err error) { - r1, _, e1 := syscall.Syscall9(procCryptProtectData.Addr(), 7, uintptr(unsafe.Pointer(dataIn)), uintptr(unsafe.Pointer(name)), uintptr(unsafe.Pointer(optionalEntropy)), uintptr(reserved), uintptr(promptStruct), uintptr(flags), uintptr(unsafe.Pointer(dataOut)), 0, 0) - if r1 == 0 { - if e1 != 0 { - err = errnoErr(e1) - } else { - err = syscall.EINVAL - } - } - return -} - -func cryptUnprotectData(dataIn *dpBlob, name **uint16, optionalEntropy *dpBlob, reserved uintptr, promptStruct uintptr, flags uint32, dataOut *dpBlob) (err error) { - r1, _, e1 := syscall.Syscall9(procCryptUnprotectData.Addr(), 7, uintptr(unsafe.Pointer(dataIn)), uintptr(unsafe.Pointer(name)), uintptr(unsafe.Pointer(optionalEntropy)), uintptr(reserved), uintptr(promptStruct), uintptr(flags), uintptr(unsafe.Pointer(dataOut)), 0, 0) - if r1 == 0 { - if e1 != 0 { - err = errnoErr(e1) - } else { - err = syscall.EINVAL - } - } - return -} |