|author||Paul Jackson <email@example.com>||2006-12-22 01:06:10 -0800|
|committer||Linus Torvalds <firstname.lastname@example.org>||2006-12-22 08:55:46 -0800|
|parent||[PATCH] KVM: API versioning (diff)|
[PATCH] CONFIG_VM_EVENT_COUNTER comment decrustify
The VM event counters, enabled by CONFIG_VM_EVENT_COUNTERS, which provides VM event counters in /proc/vmstat, has become more essential to non-EMBEDDED kernel configurations than they were in the past. Comments in the code and the Kconfig configuration explanation were stale, downplaying their role excessively. Refresh those comments to correctly reflect the current role of VM event counters. Signed-off-by: Paul Jackson <email@example.com> Acked-by: Christoph Lameter <firstname.lastname@example.org> Signed-off-by: Andrew Morton <email@example.com> Signed-off-by: Linus Torvalds <firstname.lastname@example.org>
2 files changed, 7 insertions, 6 deletions
diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
index c89df55f6e03..532360010919 100644
@@ -10,8 +10,9 @@
* Light weight per cpu counter implementation.
- * Counters should only be incremented and no critical kernel component
- * should rely on the counter values.
+ * Counters should only be incremented. You need to set EMBEDDED
+ * to disable VM_EVENT_COUNTERS. Things like procps (vmstat,
+ * top, etc) use /proc/vmstat and depend on these counters.
* Counters are handled completely inline. On many platforms the code
* generated will simply be the increment of a global address.
diff --git a/init/Kconfig b/init/Kconfig
index f000edb3bb7a..9b1adb176ea8 100644
@@ -461,10 +461,10 @@ config VM_EVENT_COUNTERS
bool "Enable VM event counters for /proc/vmstat" if EMBEDDED
- VM event counters are only needed to for event counts to be
- shown. They have no function for the kernel itself. This
- option allows the disabling of the VM event counters.
- /proc/vmstat will only show page counts.
+ VM event counters are needed for event counts to be shown.
+ This option allows the disabling of the VM event counters
+ on EMBEDDED systems. /proc/vmstat will only show page counts
+ if VM event counters are disabled.
endmenu # General setup