diff options
| author |   Doug Berger <opendmb@gmail.com> | 2021-09-25 20:21:11 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-09-27 16:34:51 +0100 |
| commit | 50e356686fa9304f7cdc30b1fe696bde8afa79d6 (patch) | |
| tree | 20a996edf2374ecbc9823e012e3a2ddca3622a47 | |
| parent | Merge branch 'rtl8366-cleanups' (diff) | |
| download | linux-dev-50e356686fa9304f7cdc30b1fe696bde8afa79d6.tar.xz linux-dev-50e356686fa9304f7cdc30b1fe696bde8afa79d6.zip | |
net: bcmgenet: remove netif_carrier_off from adjust_link
The bcmgenet_mii_setup() function is registered as the adjust_link
callback from the phylib for the GENET driver.
The phylib always sets the netif_carrier according to phydev->link
prior to invoking the adjust_link callback, so there is no need to
repeat that in the link down case within the network driver.
Signed-off-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index ff1efd52ce16..8a9d8ceaa5bf 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -106,9 +106,6 @@ void bcmgenet_mii_setup(struct net_device *dev) /* done if nothing has changed */ if (!status_changed) return; - - /* needed for MoCA fixed PHY to reflect correct link status */ - netif_carrier_off(dev); } phy_print_status(phydev); |