diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-10-17 11:51:56 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-10-17 09:35:06 +0100 |
| commit | e0bb4659e235770e6f53b3692e958591f49448f5 (patch) | |
| tree | 7063bef29c9979b69ead17a1faf5e46a27209edd | |
| parent | net: ethernet: mtk_eth_wed: add missing put_device() in mtk_wed_add_hw() (diff) | |
| download | linux-dev-e0bb4659e235770e6f53b3692e958591f49448f5.tar.xz linux-dev-e0bb4659e235770e6f53b3692e958591f49448f5.zip | |
net: ethernet: mtk_eth_wed: add missing of_node_put()
The device_node pointer returned by of_parse_phandle() with refcount
incremented, when finish using it, the refcount need be decreased.
Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_wed.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index 09bbd05bd83c..65e01bf4b4d2 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -1072,7 +1072,7 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth, pdev = of_find_device_by_node(np); if (!pdev) - return; + goto err_of_node_put; get_device(&pdev->dev); irq = platform_get_irq(pdev, 0); @@ -1132,6 +1132,8 @@ unlock: mutex_unlock(&hw_lock); err_put_device: put_device(&pdev->dev); +err_of_node_put: + of_node_put(np); } void mtk_wed_exit(void) @@ -1152,6 +1154,7 @@ void mtk_wed_exit(void) hw_list[i] = NULL; debugfs_remove(hw->debugfs_dir); put_device(hw->dev); + of_node_put(hw->node); kfree(hw); } } |