diff options
| author |   Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-16 01:56:08 -0500 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2019-08-20 17:16:17 +0530 |
| commit | 962411b05a6d3342aa649e39cda1704c1fc042c6 (patch) | |
| tree | 3fcd55c70961c7890f96604fb013163974ea4aa9 /drivers/dma | |
| parent | dmaengine: ti: dma-crossbar: Fix a memory leak bug (diff) | |
| download | linux-dev-962411b05a6d3342aa649e39cda1704c1fc042c6.tar.xz linux-dev-962411b05a6d3342aa649e39cda1704c1fc042c6.zip | |
dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe()
If devm_request_irq() fails to disable all interrupts, no cleanup is
performed before retuning the error. To fix this issue, invoke
omap_dma_free() to do the cleanup.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938570-7528-1-git-send-email-wenwen@cs.uga.edu
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/ti/omap-dma.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c index ba27802efcd0..d07c0d5de7a2 100644 --- a/drivers/dma/ti/omap-dma.c +++ b/drivers/dma/ti/omap-dma.c @@ -1540,8 +1540,10 @@ static int omap_dma_probe(struct platform_device *pdev) rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq, IRQF_SHARED, "omap-dma-engine", od); - if (rc) + if (rc) { + omap_dma_free(od); return rc; + } } if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123) |