diff options
| author |   Mel Gorman <mel@csn.ul.ie> | 2010-03-10 22:48:34 +0000 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-19 07:12:11 -0700 |
| commit | 6757eca348fbbdd4ab1020e565f325cd6a6b2698 (patch) | |
| tree | 5180a866a033ddbfc7f9c093a94493e4f1a602a2 /drivers/pci | |
| parent | sysfs: use sysfs_bin_attr_init in firmware class driver (diff) | |
| download | linux-dev-6757eca348fbbdd4ab1020e565f325cd6a6b2698.tar.xz linux-dev-6757eca348fbbdd4ab1020e565f325cd6a6b2698.zip | |
sysfs: Initialised pci bus legacy_mem field before use
PPC64 is failing to boot the latest mmotm due to an uninitialised pointer in
pci_create_legacy_files(). The surprise is that machines boot at all and it
would appear to affect current mainline as well. This patch fixes the problem.
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/pci-sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index de296452c957..997668558e79 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -655,8 +655,8 @@ void pci_create_legacy_files(struct pci_bus *b) goto legacy_io_err; /* Allocated above after the legacy_io struct */ - sysfs_bin_attr_init(b->legacy_mem); b->legacy_mem = b->legacy_io + 1; + sysfs_bin_attr_init(b->legacy_mem); b->legacy_mem->attr.name = "legacy_mem"; b->legacy_mem->size = 1024*1024; b->legacy_mem->attr.mode = S_IRUSR | S_IWUSR; |