diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-23 16:23:27 +0530 |
|---|---|---|
| committer |   Kishon Vijay Abraham I <kishon@ti.com> | 2019-08-23 09:40:55 +0530 |
| commit | 5b43a20ac6c4c1b3445618c6e0bed6937709eea8 (patch) | |
| tree | 4ed959520c125230809ccbedd04de5f5419dc9ad /drivers/phy | |
| parent | phy: marvell: phy-armada38x-comphy: Add of_node_put() before return (diff) | |
| download | linux-dev-5b43a20ac6c4c1b3445618c6e0bed6937709eea8.tar.xz linux-dev-5b43a20ac6c4c1b3445618c6e0bed6937709eea8.zip | |
phy: marvell: phy-mvebu-cp110-comphy: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in two places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c index d98e0451f6a1..f7a16dc6e171 100644 --- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c +++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c @@ -626,12 +626,16 @@ static int mvebu_comphy_probe(struct platform_device *pdev) } lane = devm_kzalloc(&pdev->dev, sizeof(*lane), GFP_KERNEL); - if (!lane) + if (!lane) { + of_node_put(child); return -ENOMEM; + } phy = devm_phy_create(&pdev->dev, child, &mvebu_comphy_ops); - if (IS_ERR(phy)) + if (IS_ERR(phy)) { + of_node_put(child); return PTR_ERR(phy); + } lane->priv = priv; lane->mode = PHY_MODE_INVALID; |