diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-04-30 14:22:59 +0100 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2018-05-02 14:36:31 +0200 |
| commit | 882518debc8487147d618d5f26f4bb0bea1cc05b (patch) | |
| tree | 3a60446321263502e0547e1724f543ce4b2ae7f3 /drivers/pinctrl/actions | |
| parent | pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static (diff) | |
| download | linux-dev-882518debc8487147d618d5f26f4bb0bea1cc05b.tar.xz linux-dev-882518debc8487147d618d5f26f4bb0bea1cc05b.zip | |
pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.
There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
checks against *arg. This looks like an unintentional missing break so
add in the break.
Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch")
Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/actions')
| -rw-r--r-- | drivers/pinctrl/actions/pinctrl-owl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c index 928b40f71a3c..ee090697b1e9 100644 --- a/drivers/pinctrl/actions/pinctrl-owl.c +++ b/drivers/pinctrl/actions/pinctrl-owl.c @@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct owl_pingroup *g, default: return -EINVAL; } + break; case PIN_CONFIG_SLEW_RATE: if (*arg) *arg = OWL_PINCONF_SLEW_FAST; @@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g, default: return -EINVAL; } + break; case PIN_CONFIG_SLEW_RATE: if (*arg) *arg = 1; |