path: root/drivers/staging/kpc2000/TODO
diff options
authorJeremy Sowden <jeremy@azazel.net>2019-05-15 12:14:36 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-20 07:40:41 +0200
commitabb611d2c21c0a4fa8eab35dc936c80d9a07acd8 (patch)
tree34239d36167acbee96d22e6b2d5be9c0f10974c5 /drivers/staging/kpc2000/TODO
parentstaging: kpc2000: added designated initializers to two structs. (diff)
staging: kpc2000: added missing clean-up to probe_core_uio.
On error, probe_core_uio just returned an error without freeing resources which had previously been allocated. Added the missing clean-up code. Updated TODO. Signed-off-by: Jeremy Sowden <jeremy@azazel.net> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/kpc2000/TODO')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/kpc2000/TODO b/drivers/staging/kpc2000/TODO
index 8c7af29fefae..ed951acc829a 100644
--- a/drivers/staging/kpc2000/TODO
+++ b/drivers/staging/kpc2000/TODO
@@ -1,7 +1,6 @@
- the kpc_spi driver doesn't seem to let multiple transactions (to different instances of the core) happen in parallel...
- The kpc_i2c driver is a hot mess, it should probably be cleaned up a ton. It functions against current hardware though.
- pcard->card_num in kp2000_pcie_probe() is a global variable and needs atomic / locking / something better.
-- probe_core_uio() probably needs error handling
- the loop in kp2000_probe_cores() that uses probe_core_uio() also probably needs error handling
- would be nice if the AIO fileops in kpc_dma could be made to work
- probably want to add a CONFIG_ option to control compilation of the AIO functions