diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-12-08 20:01:21 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-12-12 09:38:24 +0000 |
| commit | 6cee96e09df54ae17784c0f38a49e0ed8229b825 (patch) | |
| tree | 9a0af194e6d56981436bbb49bdfb3888ead1bbcd | |
| parent | drivers: net: qlcnic: Fix potential memory leak in qlcnic_sriov_init() (diff) | |
| download | linux-6cee96e09df54ae17784c0f38a49e0ed8229b825.tar.xz linux-6cee96e09df54ae17784c0f38a49e0ed8229b825.zip | |
ethernet: s2io: don't call dev_kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.
It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.
In this case, dev_kfree_skb() is called in free_tx_buffers() to drop
the SKBs in tx buffers, when the card is down, so replace it with
dev_kfree_skb_irq() here.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/neterion/s2io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index 1d3c4474b7cb..700c05fb05b9 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -2386,7 +2386,7 @@ static void free_tx_buffers(struct s2io_nic *nic) skb = s2io_txdl_getskb(&mac_control->fifos[i], txdp, j); if (skb) { swstats->mem_freed += skb->truesize; - dev_kfree_skb(skb); + dev_kfree_skb_irq(skb); cnt++; } } |