diff options
| author |   Zhang Changzhong <zhangchangzhong@huawei.com> | 2022-10-21 09:32:24 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-10-24 13:02:18 +0100 |
| commit | 9c1eaa27ec599fcc25ed4970c0b73c247d147a2b (patch) | |
| tree | 383024e1af27011269bf6e10309f172efc52cd4a | |
| parent | net: fix UAF issue in nfqnl_nf_hook_drop() when ops_init() failed (diff) | |
| download | linux-9c1eaa27ec599fcc25ed4970c0b73c247d147a2b.tar.xz linux-9c1eaa27ec599fcc25ed4970c0b73c247d147a2b.zip | |
net: lantiq_etop: don't free skb when returning NETDEV_TX_BUSY
The ndo_start_xmit() method must not free skb when returning
NETDEV_TX_BUSY, since caller is going to requeue freed skb.
Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/lantiq_etop.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 59aab4086dcc..f5961bdcc480 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -485,7 +485,6 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev) len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len; if ((desc->ctl & (LTQ_DMA_OWN | LTQ_DMA_C)) || ch->skb[ch->dma.desc]) { - dev_kfree_skb_any(skb); netdev_err(dev, "tx ring full\n"); netif_tx_stop_queue(txq); return NETDEV_TX_BUSY; |