diff options
| author |   Eric Dumazet <edumazet@google.com> | 2023-09-22 22:03:55 +0000 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2023-10-03 10:05:22 +0200 |
| commit | a135798e6e200ecb2f864cecca6d257ba278370c (patch) | |
| tree | 0ca4e1e03b929fab5ad4b9f85642110e0c2ecd02 | |
| parent | tcp_metrics: properly set tp->snd_ssthresh in tcp_init_metrics() (diff) | |
| download | linux-a135798e6e200ecb2f864cecca6d257ba278370c.tar.xz linux-a135798e6e200ecb2f864cecca6d257ba278370c.zip | |
tcp_metrics: do not create an entry from tcp_init_metrics()
tcp_init_metrics() only wants to get metrics if they were
previously stored in the cache. Creating an entry is adding
useless costs, especially when tcp_no_metrics_save is set.
Fixes: 51c5d0c4b169 ("tcp: Maintain dynamic metrics in local cache.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | net/ipv4/tcp_metrics.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c index 0c03f564878f..7aca12c59c18 100644 --- a/net/ipv4/tcp_metrics.c +++ b/net/ipv4/tcp_metrics.c @@ -478,7 +478,7 @@ void tcp_init_metrics(struct sock *sk) goto reset; rcu_read_lock(); - tm = tcp_get_metrics(sk, dst, true); + tm = tcp_get_metrics(sk, dst, false); if (!tm) { rcu_read_unlock(); goto reset; |