diff options
| author |   Zheyu Ma <zheyuma97@gmail.com> | 2021-10-18 14:32:57 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-10-19 13:09:57 +0100 |
| commit | c69b2f46876825c726bd8a97c7fa852d8932bc32 (patch) | |
| tree | 6702ff70c0a2d11b33ba0c38260abd3f1bf6cdea /drivers/net/ethernet/cavium/thunder/nicvf_main.c | |
| parent | mISDN: Fix return values of the probe function (diff) | |
| download | linux-c69b2f46876825c726bd8a97c7fa852d8932bc32.tar.xz linux-c69b2f46876825c726bd8a97c7fa852d8932bc32.zip | |
cavium: Fix return values of the probe function
During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value > 0 as success.
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cavium/thunder/nicvf_main.c')
| -rw-r--r-- | drivers/net/ethernet/cavium/thunder/nicvf_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c index d1667b759522..a27227aeae88 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c @@ -1224,7 +1224,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic) if (ret < 0) { netdev_err(nic->netdev, "Req for #%d msix vectors failed\n", nic->num_vec); - return 1; + return ret; } sprintf(nic->irq_name[irq], "%s Mbox", "NICVF"); @@ -1243,7 +1243,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic) if (!nicvf_check_pf_ready(nic)) { nicvf_disable_intr(nic, NICVF_INTR_MBOX, 0); nicvf_unregister_interrupts(nic); - return 1; + return -EIO; } return 0; |