diff options
| author |   Nathan Chancellor <natechancellor@gmail.com> | 2020-08-21 15:25:16 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-08-24 16:13:25 -0700 |
| commit | 5978fac03ea3faf793dffeedcbe60dd8da673f89 (patch) | |
| tree | ba4b177895c845b07762e370b169605ff3180ad1 /MAINTAINERS | |
| parent | net: Get rid of consume_skb when tracing is off (diff) | |
| download | wireguard-linux-5978fac03ea3faf793dffeedcbe60dd8da673f89.tar.xz wireguard-linux-5978fac03ea3faf793dffeedcbe60dd8da673f89.zip | |
net: dsa: sja1105: Do not use address of compatible member in sja1105_check_device_id
Clang warns:
drivers/net/dsa/sja1105/sja1105_main.c:3418:38: warning: address of
array 'match->compatible' will always evaluate to 'true'
[-Wpointer-bool-conversion]
for (match = sja1105_dt_ids; match->compatible; match++) {
~~~ ~~~~~~~^~~~~~~~~~
1 warning generated.
We should check the value of the first character in compatible to see if
it is empty or not. This matches how the rest of the tree iterates over
IDs.
Fixes: 0b0e299720bb ("net: dsa: sja1105: use detected device id instead of DT one on mismatch")
Link: https://github.com/ClangBuiltLinux/linux/issues/1139
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions