diff options
| author |   Eric W. Biederman <ebiederm@xmission.com> | 2020-04-02 18:04:54 -0500 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2020-05-07 16:55:47 -0500 |
| commit | 89826cce37542f7950e8f4b9258284805e98430c (patch) | |
| tree | 6c56c7eed4eb0022a707cbd9b4d648440565bad7 /include/linux/binfmts.h | |
| parent | binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf (diff) | |
| download | wireguard-linux-89826cce37542f7950e8f4b9258284805e98430c.tar.xz wireguard-linux-89826cce37542f7950e8f4b9258284805e98430c.zip | |
exec: Make unlocking exec_update_mutex explict
With install_exec_creds updated to follow immediately after
setup_new_exec, the failure of unshare_sighand is the only
code path where exec_update_mutex is held but not explicitly
unlocked.
Update that code path to explicitly unlock exec_update_mutex.
Remove the unlocking of exec_update_mutex from free_bprm.
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'include/linux/binfmts.h')
| -rw-r--r-- | include/linux/binfmts.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h index a345d9fed3d8..6f564b9ad882 100644 --- a/include/linux/binfmts.h +++ b/include/linux/binfmts.h @@ -47,8 +47,7 @@ struct linux_binprm { secureexec:1, /* * Set by flush_old_exec, when exec_mmap has been called. - * This is past the point of no return, when the - * exec_update_mutex has been taken. + * This is past the point of no return. */ called_exec_mmap:1; #ifdef __alpha__ |