summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbluhm <bluhm@openbsd.org>2019-11-13 10:15:10 +0000
committerbluhm <bluhm@openbsd.org>2019-11-13 10:15:10 +0000
commit11cc9fe247b8b993161344fd1ac1fae9e819b6fb (patch)
tree2844cc34f2665f181312b1be473fb2797fec0d3d
parentfix shield/unshield for xmss keys: (diff)
downloadwireguard-openbsd-11cc9fe247b8b993161344fd1ac1fae9e819b6fb.tar.xz
wireguard-openbsd-11cc9fe247b8b993161344fd1ac1fae9e819b6fb.zip
Non root users must not set the parameters of pppoe(4) interfaces.
found by Ilja Van Sprundel; OK deraadt@ dlg@
-rw-r--r--sys/net/if_spppsubr.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sys/net/if_spppsubr.c b/sys/net/if_spppsubr.c
index c4558db8124..29af9375526 100644
--- a/sys/net/if_spppsubr.c
+++ b/sys/net/if_spppsubr.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: if_spppsubr.c,v 1.180 2019/11/08 07:16:29 dlg Exp $ */
+/* $OpenBSD: if_spppsubr.c,v 1.181 2019/11/13 10:15:10 bluhm Exp $ */
/*
* Synchronous PPP link level subroutines.
*
@@ -873,6 +873,8 @@ sppp_ioctl(struct ifnet *ifp, u_long cmd, void *data)
break;
case SIOCSSPPPPARAMS:
+ if ((rv = suser(curproc)) != 0)
+ break;
rv = sppp_set_params(sp, ifr);
break;