summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbrad <brad@openbsd.org>2014-12-08 16:21:38 +0000
committerbrad <brad@openbsd.org>2014-12-08 16:21:38 +0000
commit1a6cea55605542609b972ec80685d2897c650848 (patch)
tree622a8c1ea66fa93eb43fc791445f001ebea393ca
parentfix crash when trying to apply ++ without an lvalue; ok millert@ jsg@ (diff)
downloadwireguard-openbsd-1a6cea55605542609b972ec80685d2897c650848.tar.xz
wireguard-openbsd-1a6cea55605542609b972ec80685d2897c650848.zip
Remove a few foo_start() calls within ioctl handlers. Odd spot to have
them and the vast majority of the rest of the drivers do not do this. ok mikeb@
-rw-r--r--sys/dev/pci/if_bce.c7
-rw-r--r--sys/dev/pci/if_pcn.c5
-rw-r--r--sys/dev/pci/if_stge.c5
3 files changed, 3 insertions, 14 deletions
diff --git a/sys/dev/pci/if_bce.c b/sys/dev/pci/if_bce.c
index 6567177b5a4..3222eebd6db 100644
--- a/sys/dev/pci/if_bce.c
+++ b/sys/dev/pci/if_bce.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: if_bce.c,v 1.38 2014/07/22 13:12:11 mpi Exp $ */
+/* $OpenBSD: if_bce.c,v 1.39 2014/12/08 16:21:38 brad Exp $ */
/* $NetBSD: if_bce.c,v 1.3 2003/09/29 01:53:02 mrg Exp $ */
/*
@@ -510,11 +510,6 @@ bce_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data)
error = 0;
}
- if (error == 0) {
- /* Try to get more packets going. */
- bce_start(ifp);
- }
-
splx(s);
return error;
}
diff --git a/sys/dev/pci/if_pcn.c b/sys/dev/pci/if_pcn.c
index 07e92a7d703..107bc4ba58b 100644
--- a/sys/dev/pci/if_pcn.c
+++ b/sys/dev/pci/if_pcn.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: if_pcn.c,v 1.30 2014/07/22 13:12:11 mpi Exp $ */
+/* $OpenBSD: if_pcn.c,v 1.31 2014/12/08 16:21:38 brad Exp $ */
/* $NetBSD: if_pcn.c,v 1.26 2005/05/07 09:15:44 is Exp $ */
/*
@@ -1091,9 +1091,6 @@ pcn_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data)
error = 0;
}
- /* Try to get more packets going. */
- pcn_start(ifp);
-
splx(s);
return (error);
}
diff --git a/sys/dev/pci/if_stge.c b/sys/dev/pci/if_stge.c
index e19131cebc7..653e6391f09 100644
--- a/sys/dev/pci/if_stge.c
+++ b/sys/dev/pci/if_stge.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: if_stge.c,v 1.56 2014/07/22 13:12:11 mpi Exp $ */
+/* $OpenBSD: if_stge.c,v 1.57 2014/12/08 16:21:38 brad Exp $ */
/* $NetBSD: if_stge.c,v 1.27 2005/05/16 21:35:32 bouyer Exp $ */
/*-
@@ -709,9 +709,6 @@ stge_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data)
error = 0;
}
- /* Try to get more packets going. */
- stge_start(ifp);
-
splx(s);
return (error);
}