summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoryasuoka <yasuoka@openbsd.org>2015-08-02 21:48:55 +0000
committeryasuoka <yasuoka@openbsd.org>2015-08-02 21:48:55 +0000
commit791bee4745f95ef8bb60af7590bcee08b7320aad (patch)
treeb7dd9c084185b7cf5e1409cb62d6a6fe75aa1463
parentradiusd_module with libevent didn't stop when the daemon stops. Fix (diff)
downloadwireguard-openbsd-791bee4745f95ef8bb60af7590bcee08b7320aad.tar.xz
wireguard-openbsd-791bee4745f95ef8bb60af7590bcee08b7320aad.zip
Tweak XXX comments.
-rw-r--r--usr.sbin/radiusd/parse.y1
-rw-r--r--usr.sbin/radiusd/radiusd.c11
2 files changed, 5 insertions, 7 deletions
diff --git a/usr.sbin/radiusd/parse.y b/usr.sbin/radiusd/parse.y
index 095e74a7e5c..1d4fa6d0277 100644
--- a/usr.sbin/radiusd/parse.y
+++ b/usr.sbin/radiusd/parse.y
@@ -322,6 +322,7 @@ authopts : AUTHENTICATE_BY STRING {
YYERROR;
authen.auth = modref;
}
+ /* XXX decoration doesn't work for this moment. */
| DECORATE_BY str_l {
int i;
struct radiusd_module_ref *modref;
diff --git a/usr.sbin/radiusd/radiusd.c b/usr.sbin/radiusd/radiusd.c
index 58398d81412..1b0de8e020d 100644
--- a/usr.sbin/radiusd/radiusd.c
+++ b/usr.sbin/radiusd/radiusd.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: radiusd.c,v 1.4 2015/08/02 21:24:25 yasuoka Exp $ */
+/* $OpenBSD: radiusd.c,v 1.5 2015/08/02 21:48:55 yasuoka Exp $ */
/*
* Copyright (c) 2013 Internet Initiative Japan Inc.
@@ -442,12 +442,11 @@ radiusd_listen_on_event(int fd, short evmask, void *ctx)
break; /* found it */
}
if (q != NULL) {
- /* RFC 5080 suggests to answer the cached result */
log_info("Received %s(code=%d) from %s id=%d: "
"duplicate request by q=%u",
radius_code_string(req_code), req_code, peerstr,
req_id, q->id);
- // XXX
+ /* XXX RFC 5080 suggests to answer the cached result */
return;
}
@@ -546,8 +545,7 @@ radius_query_request_decoration(struct radius_query *q)
struct radiusd_module_ref *deco;
TAILQ_FOREACH(deco, &q->authen->deco, next) {
- /* XXX module is running? */
- /* XXX */
+ /* XXX decoration doesn't work for this moment. */
if (deco->module->request_decoration != NULL &&
deco->module->request_decoration(NULL, q) != 0) {
log_warnx("q=%u request decoration `%s' failed", q->id,
@@ -565,8 +563,7 @@ radius_query_response_decoration(struct radius_query *q)
struct radiusd_module_ref *deco;
TAILQ_FOREACH(deco, &q->authen->deco, next) {
- /* XXX module is running? */
- /* XXX */
+ /* XXX decoration doesn't work for this moment. */
if (deco->module->response_decoration != NULL &&
deco->module->response_decoration(NULL, q) != 0) {
log_warnx("q=%u response decoration `%s' failed", q->id,