diff options
| author |   beck <beck@openbsd.org> | 2020-01-21 05:02:53 +0000 |
|---|---|---|
| committer | beck <beck@openbsd.org> | 2020-01-21 05:02:53 +0000 |
| commit | 80ddac7a857dc0e71c0a43a951545751d8c5b91f (patch) | |
| tree | af2bc68a36221ac032598e10eafd5fd9246f19e3 | |
| parent | Clear and free the tls13_ctx that hangs off an SSL *s from (diff) | |
| download | wireguard-openbsd-80ddac7a857dc0e71c0a43a951545751d8c5b91f.tar.xz wireguard-openbsd-80ddac7a857dc0e71c0a43a951545751d8c5b91f.zip | |
Fix tls_handshake() usage which was added without checking return values
correctly. This would break ftp when the handshake doesn't complete in one
shot. (noticed when making tls 1.3 connections to cloudflare.cdn)
ok jsing@
| -rw-r--r-- | usr.bin/ftp/fetch.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/usr.bin/ftp/fetch.c b/usr.bin/ftp/fetch.c index 64c925230e9..c5954a57df6 100644 --- a/usr.bin/ftp/fetch.c +++ b/usr.bin/ftp/fetch.c @@ -1,4 +1,4 @@ -/* $OpenBSD: fetch.c,v 1.186 2020/01/15 14:49:38 jca Exp $ */ +/* $OpenBSD: fetch.c,v 1.187 2020/01/21 05:02:53 beck Exp $ */ /* $NetBSD: fetch.c,v 1.14 1997/08/18 10:20:20 lukem Exp $ */ /*- @@ -631,6 +631,7 @@ noslash: #ifndef NOSSL if (ishttpsurl) { + ssize_t ret; if (proxyenv && sslpath) { ishttpsurl = 0; proxyurl = NULL; @@ -646,16 +647,19 @@ noslash: goto cleanup_url_get; } if (tls_configure(tls, tls_config) != 0) { - fprintf(ttyout, "SSL configuration failure: %s\n", + fprintf(ttyout, "TLS configuration failure: %s\n", tls_error(tls)); goto cleanup_url_get; } if (tls_connect_socket(tls, fd, sslhost) != 0) { - fprintf(ttyout, "SSL failure: %s\n", tls_error(tls)); + fprintf(ttyout, "TLS connect failure: %s\n", tls_error(tls)); goto cleanup_url_get; } - if (tls_handshake(tls) != 0) { - fprintf(ttyout, "SSL failure: %s\n", tls_error(tls)); + do { + ret = tls_handshake(tls); + } while (ret == TLS_WANT_POLLIN || ret == TLS_WANT_POLLOUT); + if (ret != 0) { + fprintf(ttyout, "TLS handshake failure: %s\n", tls_error(tls)); goto cleanup_url_get; } fin = funopen(tls, stdio_tls_read_wrapper, |