summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormpf <mpf@openbsd.org>2006-01-25 00:31:05 +0000
committermpf <mpf@openbsd.org>2006-01-25 00:31:05 +0000
commit8bb88694b2a18516f461af5bad30a3cbe44891a3 (patch)
tree4b00aa501947a54942a958c56e95247844281dd8
parentInitial stab at glenv(4), a driver for the GL518SM. (diff)
downloadwireguard-openbsd-8bb88694b2a18516f461af5bad30a3cbe44891a3.tar.xz
wireguard-openbsd-8bb88694b2a18516f461af5bad30a3cbe44891a3.zip
Remove gratuitous fetch_state() calls in state_change().
It could race with a second incoming routing message, which would not trigger any action, because of the already updated status cache. Found by markus@. OK markus@ mcbride@
-rw-r--r--usr.sbin/ifstated/ifstated.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/usr.sbin/ifstated/ifstated.c b/usr.sbin/ifstated/ifstated.c
index 893e94b9f4a..9ae87d358e8 100644
--- a/usr.sbin/ifstated/ifstated.c
+++ b/usr.sbin/ifstated/ifstated.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ifstated.c,v 1.23 2006/01/23 22:19:40 mpf Exp $ */
+/* $OpenBSD: ifstated.c,v 1.24 2006/01/25 00:31:05 mpf Exp $ */
/*
* Copyright (c) 2004 Marco Pfatschbacher <mpf@openbsd.org>
@@ -516,9 +516,7 @@ state_change(void)
conf->nextstate = NULL;
conf->curstate->entered = time(NULL);
external_evtimer_setup(conf->curstate, IFSD_EVTIMER_ADD);
- fetch_state();
do_action(conf->curstate->init);
- fetch_state();
}
}