sync to 1.9.7: kristaps@ renamed part of the DECL_ARGS :-(

intricately mixed with three minor .Bd fixes

1 files changed, 216 insertions, 244 deletions

diff --git a/usr.bin/mandoc/mdoc_term.c b/usr.bin/mandoc/mdoc_term.c
index e3a5ebf6220..1251c29fd05 100644
--- a/usr.bin/mandoc/mdoc_term.c
+++ b/usr.bin/mandoc/mdoc_term.c
@@ -1,4 +1,4 @@
-/*	$Id: mdoc_term.c,v 1.59 2009/10/19 16:51:08 schwarze Exp $ */
+/*	$Id: mdoc_term.c,v 1.60 2009/10/19 21:35:43 schwarze Exp $ */
 /*
  * Copyright (c) 2008, 2009 Kristaps Dzonsons <kristaps@kth.se>
  *
@@ -72,8 +72,8 @@ struct	termpair {
 
 #define	DECL_ARGS struct termp *p, \
 		  struct termpair *pair, \
-	  	  const struct mdoc_meta *meta, \
-		  const struct mdoc_node *node
+	  	  const struct mdoc_meta *m, \
+		  const struct mdoc_node *n
 
 struct	termact {
 	int	(*pre)(DECL_ARGS);
@@ -306,9 +306,9 @@ static void
 print_body(DECL_ARGS)
 {
 
-	print_node(p, pair, meta, node);
-	if (node->next)
-		print_body(p, pair, meta, node->next);
+	print_node(p, pair, m, n);
+	if (n->next)
+		print_body(p, pair, m, n->next);
 }
 
 
@@ -329,15 +329,13 @@ print_node(DECL_ARGS)
 	bzero(&npair, sizeof(struct termpair));
 	npair.ppair = pair;
 
-	if (MDOC_TEXT != node->type) {
-		if (termacts[node->tok].pre)
-			chld = (*termacts[node->tok].pre)
-				(p, &npair, meta, node);
+	if (MDOC_TEXT != n->type) {
+		if (termacts[n->tok].pre)
+			chld = (*termacts[n->tok].pre)(p, &npair, m, n);
 	} else 
-		term_word(p, node->string);
-
-	if (chld && node->child)
-		print_body(p, &npair, meta, node->child);
+		term_word(p, n->string); 
+	if (chld && n->child)
+		print_body(p, &npair, m, n->child);
 
 	/*
 	 * XXX - if bold/under were to span scopes, this wouldn't be
@@ -348,10 +346,9 @@ print_node(DECL_ARGS)
 	p->bold = bold;
 	p->under = under;
 
-	if (MDOC_TEXT != node->type)
-		if (termacts[node->tok].post)
-			(*termacts[node->tok].post)
-				(p, &npair, meta, node);
+	if (MDOC_TEXT != n->type)
+		if (termacts[n->tok].post)
+			(*termacts[n->tok].post)(p, &npair, m, n);
 
 	p->offset = offset;
 	p->rmargin = rmargin;
@@ -378,12 +375,12 @@ print_foot(DECL_ARGS)
 	if (NULL == (os = malloc(p->rmargin)))
 		err(EXIT_FAILURE, "malloc");
 
-	tm = localtime(&meta->date);
+	tm = localtime(&m->date);
 
 	if (0 == strftime(buf, p->rmargin, "%B %e, %Y", tm))
 		err(EXIT_FAILURE, "strftime");
 
-	(void)strlcpy(os, meta->os, p->rmargin);
+	(void)strlcpy(os, m->os, p->rmargin);
 
 	term_vspace(p);
 
@@ -446,16 +443,16 @@ print_head(DECL_ARGS)
 	 * switches on the manual section.
 	 */
 
-	assert(meta->vol);
-	(void)strlcpy(buf, meta->vol, p->rmargin);
+	assert(m->vol);
+	(void)strlcpy(buf, m->vol, p->rmargin);
 
-	if (meta->arch) {
+	if (m->arch) {
 		(void)strlcat(buf, " (", p->rmargin);
-		(void)strlcat(buf, meta->arch, p->rmargin);
+		(void)strlcat(buf, m->arch, p->rmargin);
 		(void)strlcat(buf, ")", p->rmargin);
 	}
 
-	snprintf(title, p->rmargin, "%s(%d)", meta->title, meta->msec);
+	snprintf(title, p->rmargin, "%s(%d)", m->title, m->msec);
 
 	p->offset = 0;
 	p->rmargin = (p->maxrmargin - strlen(buf) + 1) / 2;
@@ -629,50 +626,40 @@ arg_getattrs(const int *keys, int *vals,
 static void
 fmt_block_vspace(struct termp *p, 
 		const struct mdoc_node *bl, 
-		const struct mdoc_node *node)
+		const struct mdoc_node *n)
 {
-	const struct mdoc_node *n;
+	const struct mdoc_node	*nn;
 
 	term_newln(p);
-
-	if (MDOC_Bl == bl->tok && arg_hasattr(MDOC_Compact, bl))
+	if (arg_hasattr(MDOC_Compact, bl))
 		return;
-	assert(node);
 
-	/*
-	 * Search through our prior nodes.  If we follow a `Ss' or `Sh',
-	 * then don't vspace.
-	 */
+	/* Do not vspace directly after Ss/Sh. */
 
-	for (n = node; n; n = n->parent) {
-		if (MDOC_BLOCK != n->type)
+	for (nn = n; nn; nn = nn->parent) {
+		if (MDOC_BLOCK != nn->type)
 			continue;
-		if (MDOC_Ss == n->tok)
+		if (MDOC_Ss == nn->tok)
 			return;
-		if (MDOC_Sh == n->tok)
+		if (MDOC_Sh == nn->tok)
 			return;
-		if (NULL == n->prev)
+		if (NULL == nn->prev)
 			continue;
 		break;
 	}
 
-	/* 
-	 * XXX - not documented: a `-column' does not ever assert vspace
-	 * within the list.
-	 */
+	/* A `-column' does not assert vspace within the list. */
 
 	if (MDOC_Bl == bl->tok && arg_hasattr(MDOC_Column, bl))
-		if (node->prev && MDOC_It == node->prev->tok)
+		if (n->prev && MDOC_It == n->prev->tok)
 			return;
 
-	/*
-	 * XXX - not documented: a `-diag' without a body does not
-	 * assert a vspace prior to the next element. 
-	 */
+	/* A `-diag' without body does not vspace. */
+
 	if (MDOC_Bl == bl->tok && arg_hasattr(MDOC_Diag, bl)) 
-		if (node->prev && MDOC_It == node->prev->tok) {
-			assert(node->prev->body);
-			if (NULL == node->prev->body->child)
+		if (n->prev && MDOC_It == n->prev->tok) {
+			assert(n->prev->body);
+			if (NULL == n->prev->body->child)
 				return;
 		}
 
@@ -685,7 +672,7 @@ static int
 termp_dq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 
 	term_word(p, "\\(lq");
@@ -699,7 +686,7 @@ static void
 termp_dq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 
 	p->flags |= TERMP_NOSPACE;
@@ -711,17 +698,17 @@ termp_dq_post(DECL_ARGS)
 static int
 termp_it_pre(DECL_ARGS)
 {
-	const struct mdoc_node *bl, *n;
+	const struct mdoc_node *bl, *nn;
 	char		        buf[7];
 	int		        i, type, keys[3], vals[3];
 	size_t		        width, offset;
 
-	if (MDOC_BLOCK == node->type) {
-		fmt_block_vspace(p, node->parent->parent, node);
+	if (MDOC_BLOCK == n->type) {
+		fmt_block_vspace(p, n->parent->parent, n);
 		return(1);
 	}
 
-	bl = node->parent->parent->parent;
+	bl = n->parent->parent->parent;
 
 	/* Save parent attributes. */
 
@@ -746,7 +733,7 @@ termp_it_pre(DECL_ARGS)
 
 	switch (type) {
 	case (MDOC_Column):
-		if (MDOC_BODY == node->type)
+		if (MDOC_BODY == n->type)
 			break;
 		/* 
 		 * Work around groff's column handling.  The offset is
@@ -757,9 +744,9 @@ termp_it_pre(DECL_ARGS)
 		 * the 0 will be adjusted to default 10 or, if in the
 		 * last column case, set to stretch to the margin).
 		 */
-		for (i = 0, n = node->prev; n && 
+		for (i = 0, nn = n->prev; nn && 
 				i < (int)bl->args->argv[vals[2]].sz; 
-				n = n->prev, i++)
+				nn = nn->prev, i++)
 			offset += arg_width 
 				(&bl->args->argv[vals[2]], i);
 
@@ -822,11 +809,11 @@ termp_it_pre(DECL_ARGS)
 
 	switch (type) {
 	case (MDOC_Diag):
-		if (MDOC_BODY == node->type)
+		if (MDOC_BODY == n->type)
 			term_word(p, "\\ \\ ");
 		break;
 	case (MDOC_Inset):
-		if (MDOC_BODY == node->type) 
+		if (MDOC_BODY == n->type) 
 			term_word(p, "\\ ");
 		break;
 	default:
@@ -837,7 +824,7 @@ termp_it_pre(DECL_ARGS)
 
 	switch (type) {
 	case (MDOC_Diag):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			p->bold++;
 		break;
 	default:
@@ -860,18 +847,18 @@ termp_it_pre(DECL_ARGS)
 	case (MDOC_Enum):
 		/* FALLTHROUGH */
 	case (MDOC_Hyphen):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			p->flags |= TERMP_NOBREAK;
 		else
 			p->flags |= TERMP_NOLPAD;
 		break;
 	case (MDOC_Hang):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			p->flags |= TERMP_NOBREAK;
 		else
 			p->flags |= TERMP_NOLPAD;
 
-		if (MDOC_HEAD != node->type)
+		if (MDOC_HEAD != n->type)
 			break;
 
 		/*
@@ -880,38 +867,38 @@ termp_it_pre(DECL_ARGS)
 		 * the "overstep" effect in term_flushln() and treat
 		 * this as a `-ohang' list instead.
 		 */
-		if (node->next->child && 
-				(MDOC_Bl == node->next->child->tok ||
-				 MDOC_Bd == node->next->child->tok)) {
+		if (n->next->child && 
+				(MDOC_Bl == n->next->child->tok ||
+				 MDOC_Bd == n->next->child->tok)) {
 			p->flags &= ~TERMP_NOBREAK;
 			p->flags &= ~TERMP_NOLPAD;
 		} else
 			p->flags |= TERMP_HANG;
 		break;
 	case (MDOC_Tag):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			p->flags |= TERMP_NOBREAK | TERMP_TWOSPACE;
 		else
 			p->flags |= TERMP_NOLPAD;
 
-		if (MDOC_HEAD != node->type)
+		if (MDOC_HEAD != n->type)
 			break;
-		if (NULL == node->next || NULL == node->next->child)
+		if (NULL == n->next || NULL == n->next->child)
 			p->flags |= TERMP_DANGLE;
 		break;
 	case (MDOC_Column):
-		if (MDOC_HEAD == node->type) {
-			assert(node->next);
-			if (MDOC_BODY == node->next->type)
+		if (MDOC_HEAD == n->type) {
+			assert(n->next);
+			if (MDOC_BODY == n->next->type)
 				p->flags &= ~TERMP_NOBREAK;
 			else
 				p->flags |= TERMP_NOBREAK;
-			if (node->prev) 
+			if (n->prev) 
 				p->flags |= TERMP_NOLPAD;
 		}
 		break;
 	case (MDOC_Diag):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			p->flags |= TERMP_NOBREAK;
 		break;
 	default:
@@ -933,9 +920,9 @@ termp_it_pre(DECL_ARGS)
 		 * don't want to recalculate rmargin and offsets when
 		 * using `Bd' or `Bl' within `-hang' overstep lists.
 		 */
-		if (MDOC_HEAD == node->type && node->next->child &&
-				(MDOC_Bl == node->next->child->tok || 
-				 MDOC_Bd == node->next->child->tok))
+		if (MDOC_HEAD == n->type && n->next->child &&
+				(MDOC_Bl == n->next->child->tok || 
+				 MDOC_Bd == n->next->child->tok))
 			break;
 		/* FALLTHROUGH */
 	case (MDOC_Bullet):
@@ -948,7 +935,7 @@ termp_it_pre(DECL_ARGS)
 		/* FALLTHROUGH */
 	case (MDOC_Tag):
 		assert(width);
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			p->rmargin = p->offset + width;
 		else 
 			p->offset += width;
@@ -960,8 +947,8 @@ termp_it_pre(DECL_ARGS)
 		 * XXX - this behaviour is not documented: the
 		 * right-most column is filled to the right margin.
 		 */
-		if (MDOC_HEAD == node->type &&
-				MDOC_BODY == node->next->type)
+		if (MDOC_HEAD == n->type &&
+				MDOC_BODY == n->next->type)
 			p->rmargin = p->maxrmargin;
 		break;
 	default:
@@ -973,7 +960,7 @@ termp_it_pre(DECL_ARGS)
 	 * HEAD character (temporarily bold, in some cases).  
 	 */
 
-	if (MDOC_HEAD == node->type)
+	if (MDOC_HEAD == n->type)
 		switch (type) {
 		case (MDOC_Bullet):
 			p->bold++;
@@ -1011,11 +998,11 @@ termp_it_pre(DECL_ARGS)
 	case (MDOC_Hyphen):
 		/* FALLTHROUGH */
 	case (MDOC_Enum):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			return(0);
 		break;
 	case (MDOC_Column):
-		if (MDOC_BODY == node->type)
+		if (MDOC_BODY == n->type)
 			return(0);
 		break;
 	default:
@@ -1032,10 +1019,10 @@ termp_it_post(DECL_ARGS)
 {
 	int		   type;
 
-	if (MDOC_BODY != node->type && MDOC_HEAD != node->type)
+	if (MDOC_BODY != n->type && MDOC_HEAD != n->type)
 		return;
 
-	type = arg_listtype(node->parent->parent->parent);
+	type = arg_listtype(n->parent->parent->parent);
 	assert(-1 != type);
 
 	switch (type) {
@@ -1044,11 +1031,11 @@ termp_it_post(DECL_ARGS)
 	case (MDOC_Diag):
 		/* FALLTHROUGH */
 	case (MDOC_Inset):
-		if (MDOC_BODY == node->type)
+		if (MDOC_BODY == n->type)
 			term_flushln(p);
 		break;
 	case (MDOC_Column):
-		if (MDOC_HEAD == node->type)
+		if (MDOC_HEAD == n->type)
 			term_flushln(p);
 		break;
 	default:
@@ -1065,11 +1052,11 @@ static int
 termp_nm_pre(DECL_ARGS)
 {
 
-	if (SEC_SYNOPSIS == node->sec)
+	if (SEC_SYNOPSIS == n->sec)
 		term_newln(p);
 	p->bold++;
-	if (NULL == node->child)
-		term_word(p, meta->name);
+	if (NULL == n->child)
+		term_word(p, m->name);
 	return(1);
 }
 
@@ -1091,20 +1078,19 @@ static int
 termp_an_pre(DECL_ARGS)
 {
 
-	if (NULL == node->child)
+	if (NULL == n->child)
 		return(1);
 
 	/*
-	 * XXX: this is poorly documented.  If not in the AUTHORS
-	 * section, `An -split' will cause newlines to occur before the
-	 * author name.  If in the AUTHORS section, by default, the
-	 * first `An' invocation is nosplit, then all subsequent ones,
-	 * regardless of whether interspersed with other macros/text,
-	 * are split.  -split, in this case, will override the condition
-	 * of the implied first -nosplit.
+	 * If not in the AUTHORS section, `An -split' will cause
+	 * newlines to occur before the author name.  If in the AUTHORS
+	 * section, by default, the first `An' invocation is nosplit,
+	 * then all subsequent ones, regardless of whether interspersed
+	 * with other macros/text, are split.  -split, in this case,
+	 * will override the condition of the implied first -nosplit.
 	 */
 	
-	if (node->sec == SEC_AUTHORS) {
+	if (n->sec == SEC_AUTHORS) {
 		if ( ! (TERMP_ANPREC & p->flags)) {
 			if (TERMP_SPLIT & p->flags)
 				term_newln(p);
@@ -1128,13 +1114,13 @@ static void
 termp_an_post(DECL_ARGS)
 {
 
-	if (node->child) {
-		if (SEC_AUTHORS == node->sec)
+	if (n->child) {
+		if (SEC_AUTHORS == n->sec)
 			p->flags |= TERMP_ANPREC;
 		return;
 	}
 
-	if (arg_getattr(MDOC_Split, node) > -1) {
+	if (arg_getattr(MDOC_Split, n) > -1) {
 		p->flags &= ~TERMP_NOSPLIT;
 		p->flags |= TERMP_SPLIT;
 	} else {
@@ -1160,9 +1146,9 @@ static int
 termp_rs_pre(DECL_ARGS)
 {
 
-	if (SEC_SEE_ALSO != node->sec)
+	if (SEC_SEE_ALSO != n->sec)
 		return(1);
-	if (MDOC_BLOCK == node->type && node->prev)
+	if (MDOC_BLOCK == n->type && n->prev)
 		term_vspace(p);
 	return(1);
 }
@@ -1177,9 +1163,7 @@ termp_rv_pre(DECL_ARGS)
 	term_newln(p);
 	term_word(p, "The");
 
-	nn = node->child;
-	assert(nn);
-	for ( ; nn; nn = nn->next) {
+	for (nn = n->child; nn; nn = nn->next) {
 		p->bold++;
 		term_word(p, nn->string);
 		p->bold--;
@@ -1192,7 +1176,7 @@ termp_rv_pre(DECL_ARGS)
 			term_word(p, "()");
 	}
 
-	if (node->child->next)
+	if (n->child->next)
 		term_word(p, "functions return");
 	else
 		term_word(p, "function returns");
@@ -1218,9 +1202,7 @@ termp_ex_pre(DECL_ARGS)
 
 	term_word(p, "The");
 
-	nn = node->child;
-	assert(nn);
-	for ( ; nn; nn = nn->next) {
+	for (nn = n->child; nn; nn = nn->next) {
 		p->bold++;
 		term_word(p, nn->string);
 		p->bold--;
@@ -1233,7 +1215,7 @@ termp_ex_pre(DECL_ARGS)
 			p->flags &= ~TERMP_NOSPACE;
 	}
 
-	if (node->child->next)
+	if (n->child->next)
 		term_word(p, "utilities exit");
 	else
 		term_word(p, "utility exits");
@@ -1249,7 +1231,7 @@ static int
 termp_nd_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 
 #if defined(__OpenBSD__) || defined(__linux__)
@@ -1266,7 +1248,7 @@ static void
 termp_bl_post(DECL_ARGS)
 {
 
-	if (MDOC_BLOCK == node->type)
+	if (MDOC_BLOCK == n->type)
 		term_newln(p);
 }
 
@@ -1276,7 +1258,7 @@ static void
 termp_op_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type) 
+	if (MDOC_BODY != n->type) 
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "\\(rB");
@@ -1287,20 +1269,21 @@ termp_op_post(DECL_ARGS)
 static int
 termp_xr_pre(DECL_ARGS)
 {
-	const struct mdoc_node *n;
+	const struct mdoc_node *nn;
 
-	assert(node->child && MDOC_TEXT == node->child->type);
-	n = node->child;
+	assert(n->child && MDOC_TEXT == n->child->type);
+	nn = n->child;
 
-	term_word(p, n->string);
-	if (NULL == (n = n->next)) 
+	term_word(p, nn->string);
+	if (NULL == (nn = nn->next)) 
 		return(0);
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "(");
 	p->flags |= TERMP_NOSPACE;
-	term_word(p, n->string);
+	term_word(p, nn->string);
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, ")");
+
 	return(0);
 }
 
@@ -1310,11 +1293,11 @@ static void
 termp_vt_post(DECL_ARGS)
 {
 
-	if (node->sec != SEC_SYNOPSIS)
+	if (n->sec != SEC_SYNOPSIS)
 		return;
-	if (node->next && MDOC_Vt == node->next->tok)
+	if (n->next && MDOC_Vt == n->next->tok)
 		term_newln(p);
-	else if (node->next)
+	else if (n->next)
 		term_vspace(p);
 }
 
@@ -1334,11 +1317,11 @@ static void
 termp_fd_post(DECL_ARGS)
 {
 
-	if (node->sec != SEC_SYNOPSIS)
+	if (n->sec != SEC_SYNOPSIS)
 		return;
 
 	term_newln(p);
-	if (node->next && MDOC_Fd != node->next->tok)
+	if (n->next && MDOC_Fd != n->next->tok)
 		term_vspace(p);
 }
 
@@ -1347,14 +1330,13 @@ termp_fd_post(DECL_ARGS)
 static int
 termp_sh_pre(DECL_ARGS)
 {
-	/* 
-	 * XXX: undocumented: using two `Sh' macros in sequence has no
-	 * vspace between calls, only a newline.
-	 */
-	switch (node->type) {
+
+	/* No vspace between consecutive `Sh' calls. */
+
+	switch (n->type) {
 	case (MDOC_BLOCK):
-		if (node->prev && MDOC_Sh == node->prev->tok)
-			if (NULL == node->prev->body->child)
+		if (n->prev && MDOC_Sh == n->prev->tok)
+			if (NULL == n->prev->body->child)
 				break;
 		term_vspace(p);
 		break;
@@ -1376,7 +1358,7 @@ static void
 termp_sh_post(DECL_ARGS)
 {
 
-	switch (node->type) {
+	switch (n->type) {
 	case (MDOC_HEAD):
 		term_newln(p);
 		break;
@@ -1395,7 +1377,7 @@ static int
 termp_op_pre(DECL_ARGS)
 {
 
-	switch (node->type) {
+	switch (n->type) {
 	case (MDOC_BODY):
 		term_word(p, "\\(lB");
 		p->flags |= TERMP_NOSPACE;
@@ -1422,7 +1404,7 @@ static void
 termp_lb_post(DECL_ARGS)
 {
 
-	if (SEC_LIBRARY == node->sec)
+	if (SEC_LIBRARY == n->sec)
 		term_newln(p);
 }
 
@@ -1433,7 +1415,7 @@ termp_ud_pre(DECL_ARGS)
 {
 
 	term_word(p, "currently under development.");
-	return(1);
+	return(0);
 }
 
 
@@ -1442,7 +1424,7 @@ static int
 termp_d1_pre(DECL_ARGS)
 {
 
-	if (MDOC_BLOCK != node->type)
+	if (MDOC_BLOCK != n->type)
 		return(1);
 	term_newln(p);
 	p->offset += (INDENT + 1);
@@ -1455,7 +1437,7 @@ static void
 termp_d1_post(DECL_ARGS)
 {
 
-	if (MDOC_BLOCK != node->type) 
+	if (MDOC_BLOCK != n->type) 
 		return;
 	term_newln(p);
 }
@@ -1466,7 +1448,7 @@ static int
 termp_aq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 	term_word(p, "\\(la");
 	p->flags |= TERMP_NOSPACE;
@@ -1479,7 +1461,7 @@ static void
 termp_aq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "\\(ra");
@@ -1491,8 +1473,8 @@ static int
 termp_ft_pre(DECL_ARGS)
 {
 
-	if (SEC_SYNOPSIS == node->sec)
-		if (node->prev && MDOC_Fo == node->prev->tok)
+	if (SEC_SYNOPSIS == n->sec)
+		if (n->prev && MDOC_Fo == n->prev->tok)
 			term_vspace(p);
 	p->under++;
 	return(1);
@@ -1504,7 +1486,7 @@ static void
 termp_ft_post(DECL_ARGS)
 {
 
-	if (SEC_SYNOPSIS == node->sec)
+	if (SEC_SYNOPSIS == n->sec)
 		term_newln(p);
 }
 
@@ -1513,26 +1495,26 @@ termp_ft_post(DECL_ARGS)
 static int
 termp_fn_pre(DECL_ARGS)
 {
-	const struct mdoc_node *n;
+	const struct mdoc_node	*nn;
 
 	p->bold++;
-	term_word(p, node->child->string);
+	term_word(p, n->child->string);
 	p->bold--;
 
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "(");
 
-	for (n = node->child->next; n; n = n->next) {
+	for (nn = n->child->next; nn; nn = nn->next) {
 		p->under++;
-		term_word(p, n->string);
+		term_word(p, nn->string);
 		p->under--;
-		if (n->next)
+		if (nn->next)
 			term_word(p, ",");
 	}
 
 	term_word(p, ")");
 
-	if (SEC_SYNOPSIS == node->sec)
+	if (SEC_SYNOPSIS == n->sec)
 		term_word(p, ";");
 
 	return(0);
@@ -1544,7 +1526,7 @@ static void
 termp_fn_post(DECL_ARGS)
 {
 
-	if (node->sec == SEC_SYNOPSIS && node->next)
+	if (n->sec == SEC_SYNOPSIS && n->next)
 		term_vspace(p);
 }
 
@@ -1553,22 +1535,22 @@ termp_fn_post(DECL_ARGS)
 static int
 termp_fa_pre(DECL_ARGS)
 {
-	struct mdoc_node *n;
+	const struct mdoc_node	*nn;
 
-	if (node->parent->tok != MDOC_Fo) {
+	if (n->parent->tok != MDOC_Fo) {
 		p->under++;
 		return(1);
 	}
 
-	for (n = node->child; n; n = n->next) {
+	for (nn = n->child; nn; nn = nn->next) {
 		p->under++;
-		term_word(p, n->string);
+		term_word(p, nn->string);
 		p->under--;
-		if (n->next)
+		if (nn->next)
 			term_word(p, ",");
 	}
 
-	if (node->child && node->next && node->next->tok == MDOC_Fa)
+	if (n->child && n->next && n->next->tok == MDOC_Fa)
 		term_word(p, ",");
 
 	return(0);
@@ -1579,30 +1561,19 @@ termp_fa_pre(DECL_ARGS)
 static int
 termp_bd_pre(DECL_ARGS)
 {
-	int	         i, type;
-
-	/*
-	 * This is fairly tricky due primarily to crappy documentation.
-	 * If -ragged or -filled are specified, the block does nothing
-	 * but change the indentation.
-	 *
-	 * If, on the other hand, -unfilled or -literal are specified,
-	 * then the game changes.  Text is printed exactly as entered in
-	 * the display: if a macro line, a newline is appended to the
-	 * line.  Blank lines are allowed.
-	 */
+	int	         	 i, type;
+	const struct mdoc_node	*nn;
 
-	if (MDOC_BLOCK == node->type) {
-		fmt_block_vspace(p, node, node);
+	if (MDOC_BLOCK == n->type) {
+		fmt_block_vspace(p, n, n);
 		return(1);
-	} else if (MDOC_BODY != node->type)
+	} else if (MDOC_BODY != n->type)
 		return(1);
 
-	assert(node->parent->args);
+	nn = n->parent;
 
-	for (type = -1, i = 0; -1 == type && 
-			i < (int)node->parent->args->argc; i++) {
-		switch (node->parent->args->argv[i].arg) {
+	for (type = -1, i = 0; i < (int)nn->args->argc; i++) {
+		switch (nn->args->argv[i].arg) {
 		case (MDOC_Ragged):
 			/* FALLTHROUGH */
 		case (MDOC_Filled):
@@ -1610,32 +1581,36 @@ termp_bd_pre(DECL_ARGS)
 		case (MDOC_Unfilled):
 			/* FALLTHROUGH */
 		case (MDOC_Literal):
-			type = node->parent->args->argv[i].arg;
+			type = nn->args->argv[i].arg;
+			break;
+		case (MDOC_Offset):
+			p->offset += arg_offset(&nn->args->argv[i]);
 			break;
 		default:
 			break;
 		}
 	}
+
+	/*
+	 * If -ragged or -filled are specified, the block does nothing
+	 * but change the indentation.  If -unfilled or -literal are
+	 * specified, text is printed exactly as entered in the display:
+	 * for macro lines, a newline is appended to the line.  Blank
+	 * lines are allowed.
+	 */
 	
 	assert(type > -1);
-
-	i = arg_getattr(MDOC_Offset, node->parent);
-	if (-1 != i)
-		p->offset += arg_offset(&node->parent->args->argv[i]);
-
-	switch (type) {
-	case (MDOC_Literal):
-		/* FALLTHROUGH */
-	case (MDOC_Unfilled):
-		break;
-	default:
+	if (MDOC_Literal != type && MDOC_Unfilled != type)
 		return(1);
-	}
 
-	for (node = node->child; node; node = node->next) {
+	for (nn = n->child; nn; nn = nn->next) {
 		p->flags |= TERMP_NOSPACE;
-		print_node(p, pair, meta, node);
-		if (node->next)
+		print_node(p, pair, m, nn);
+		if (NULL == nn->next)
+			continue;
+		if (nn->prev && nn->prev->line < nn->line)
+			term_flushln(p);
+		else if (NULL == nn->prev)
 			term_flushln(p);
 	}
 
@@ -1648,7 +1623,7 @@ static void
 termp_bd_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type) 
+	if (MDOC_BODY != n->type) 
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_flushln(p);
@@ -1660,7 +1635,7 @@ static int
 termp_qq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 	term_word(p, "\"");
 	p->flags |= TERMP_NOSPACE;
@@ -1673,7 +1648,7 @@ static void
 termp_qq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "\"");
@@ -1685,7 +1660,7 @@ static void
 termp_bx_post(DECL_ARGS)
 {
 
-	if (node->child)
+	if (n->child)
 		p->flags |= TERMP_NOSPACE;
 	term_word(p, "BSD");
 }
@@ -1698,7 +1673,7 @@ termp_xx_pre(DECL_ARGS)
 	const char	*pp;
 
 	pp = NULL;
-	switch (node->tok) {
+	switch (n->tok) {
 	case (MDOC_Bsx):
 		pp = "BSDI BSD/OS";
 		break;
@@ -1732,7 +1707,7 @@ static int
 termp_sq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 	term_word(p, "\\(oq");
 	p->flags |= TERMP_NOSPACE;
@@ -1745,7 +1720,7 @@ static void
 termp_sq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "\\(aq");
@@ -1777,10 +1752,10 @@ static int
 termp_ss_pre(DECL_ARGS)
 {
 
-	switch (node->type) {
+	switch (n->type) {
 	case (MDOC_BLOCK):
 		term_newln(p);
-		if (node->prev)
+		if (n->prev)
 			term_vspace(p);
 		break;
 	case (MDOC_HEAD):
@@ -1800,7 +1775,7 @@ static void
 termp_ss_post(DECL_ARGS)
 {
 
-	if (MDOC_HEAD == node->type)
+	if (MDOC_HEAD == n->type)
 		term_newln(p);
 }
 
@@ -1822,7 +1797,7 @@ termp_in_pre(DECL_ARGS)
 {
 
 	p->bold++;
-	if (SEC_SYNOPSIS == node->sec)
+	if (SEC_SYNOPSIS == n->sec)
 		term_word(p, "#include");
 
 	term_word(p, "<");
@@ -1841,7 +1816,7 @@ termp_in_post(DECL_ARGS)
 	term_word(p, ">");
 	p->bold--;
 
-	if (SEC_SYNOPSIS != node->sec)
+	if (SEC_SYNOPSIS != n->sec)
 		return;
 
 	term_newln(p);
@@ -1851,7 +1826,7 @@ termp_in_post(DECL_ARGS)
 	 * the <foo>; mandoc asserts a vertical space.  Since this
 	 * construction is rarely used, I think it's fine.
 	 */
-	if (node->next && MDOC_In != node->next->tok)
+	if (n->next && MDOC_In != n->next->tok)
 		term_vspace(p);
 }
 
@@ -1862,9 +1837,9 @@ termp_sp_pre(DECL_ARGS)
 {
 	int		 i, len;
 
-	switch (node->tok) {
+	switch (n->tok) {
 	case (MDOC_sp):
-		len = node->child ? atoi(node->child->string) : 1;
+		len = n->child ? atoi(n->child->string) : 1;
 		break;
 	case (MDOC_br):
 		len = 0;
@@ -1888,7 +1863,7 @@ static int
 termp_brq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 	term_word(p, "\\(lC");
 	p->flags |= TERMP_NOSPACE;
@@ -1901,7 +1876,7 @@ static void
 termp_brq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "\\(rC");
@@ -1913,7 +1888,7 @@ static int
 termp_bq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 	term_word(p, "\\(lB");
 	p->flags |= TERMP_NOSPACE;
@@ -1926,7 +1901,7 @@ static void
 termp_bq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, "\\(rB");
@@ -1938,7 +1913,7 @@ static int
 termp_pq_pre(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return(1);
 	term_word(p, "\\&(");
 	p->flags |= TERMP_NOSPACE;
@@ -1951,7 +1926,7 @@ static void
 termp_pq_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	term_word(p, ")");
 }
@@ -1961,20 +1936,20 @@ termp_pq_post(DECL_ARGS)
 static int
 termp_fo_pre(DECL_ARGS)
 {
-	const struct mdoc_node *n;
+	const struct mdoc_node *nn;
 
-	if (MDOC_BODY == node->type) {
+	if (MDOC_BODY == n->type) {
 		p->flags |= TERMP_NOSPACE;
 		term_word(p, "(");
 		p->flags |= TERMP_NOSPACE;
 		return(1);
-	} else if (MDOC_HEAD != node->type) 
+	} else if (MDOC_HEAD != n->type) 
 		return(1);
 
 	p->bold++;
-	for (n = node->child; n; n = n->next) {
-		assert(MDOC_TEXT == n->type);
-		term_word(p, n->string);
+	for (nn = n->child; nn; nn = nn->next) {
+		assert(MDOC_TEXT == nn->type);
+		term_word(p, nn->string);
 	}
 	p->bold--;
 
@@ -1987,7 +1962,7 @@ static void
 termp_fo_post(DECL_ARGS)
 {
 
-	if (MDOC_BODY != node->type)
+	if (MDOC_BODY != n->type)
 		return;
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, ")");
@@ -2001,26 +1976,26 @@ termp_fo_post(DECL_ARGS)
 static int
 termp_bf_pre(DECL_ARGS)
 {
-	const struct mdoc_node	*n;
+	const struct mdoc_node	*nn;
 
-	if (MDOC_HEAD == node->type)
+	if (MDOC_HEAD == n->type)
 		return(0);
-	else if (MDOC_BLOCK != node->type)
+	else if (MDOC_BLOCK != n->type)
 		return(1);
 
-	if (NULL == (n = node->head->child)) {
-		if (arg_hasattr(MDOC_Emphasis, node))
+	if (NULL == (nn = n->head->child)) {
+		if (arg_hasattr(MDOC_Emphasis, n))
 			p->under++;
-		else if (arg_hasattr(MDOC_Symbolic, node))
+		else if (arg_hasattr(MDOC_Symbolic, n))
 			p->bold++;
 
 		return(1);
 	} 
 
-	assert(MDOC_TEXT == n->type);
-	if (0 == strcmp("Em", n->string))
+	assert(MDOC_TEXT == nn->type);
+	if (0 == strcmp("Em", nn->string))
 		p->under++;
-	else if (0 == strcmp("Sy", n->string))
+	else if (0 == strcmp("Sy", nn->string))
 		p->bold++;
 
 	return(1);
@@ -2032,8 +2007,8 @@ static int
 termp_sm_pre(DECL_ARGS)
 {
 
-	assert(node->child && MDOC_TEXT == node->child->type);
-	if (0 == strcmp("on", node->child->string)) {
+	assert(n->child && MDOC_TEXT == n->child->type);
+	if (0 == strcmp("on", n->child->string)) {
 		p->flags &= ~TERMP_NONOSPACE;
 		p->flags &= ~TERMP_NOSPACE;
 	} else
@@ -2061,7 +2036,7 @@ termp____post(DECL_ARGS)
 {
 
 	p->flags |= TERMP_NOSPACE;
-	switch (node->tok) {
+	switch (n->tok) {
 	case (MDOC__T):
 		term_word(p, "\\(rq");
 		p->flags |= TERMP_NOSPACE;
@@ -2069,7 +2044,7 @@ termp____post(DECL_ARGS)
 	default:
 		break;
 	}
-	term_word(p, node->next ? "," : ".");
+	term_word(p, n->next ? "," : ".");
 }
 
 
@@ -2077,25 +2052,22 @@ termp____post(DECL_ARGS)
 static int
 termp_lk_pre(DECL_ARGS)
 {
-	const struct mdoc_node *n;
+	const struct mdoc_node *nn;
 
-	assert(node->child);
-	n = node->child;
-
-	if (NULL == n->next) {
+	if (NULL == (nn = n->child->next)) {
 		p->under++;
 		return(1);
 	}
 
 	p->under++;
-	term_word(p, n->string);
+	term_word(p, nn->string);
 	p->flags |= TERMP_NOSPACE;
 	term_word(p, ":");
 	p->under--;
 
 	p->bold++;
-	for (n = n->next; n; n = n->next) 
-		term_word(p, n->string);
+	for (nn = nn->next; nn; nn = nn->next) 
+		term_word(p, nn->string);
 	p->bold--;
 
 	return(0);