diff options
| author |   kevlo <kevlo@openbsd.org> | 2018-07-03 14:33:43 +0000 |
|---|---|---|
| committer | kevlo <kevlo@openbsd.org> | 2018-07-03 14:33:43 +0000 |
| commit | 92392ef7a8d0971d14f0d23f31eda0eca009ddc7 (patch) | |
| tree | 280a8905d4c2c539f6006fb79a038ba2a9284b64 | |
| parent | add a comment that could have saved me 45 minutes of wild goose chasing (diff) | |
| download | wireguard-openbsd-92392ef7a8d0971d14f0d23f31eda0eca009ddc7.tar.xz wireguard-openbsd-92392ef7a8d0971d14f0d23f31eda0eca009ddc7.zip | |
Use LIST_FOREACH construct instead of homebrew loop.
ok bluhm@, mpi@
| -rw-r--r-- | sys/dev/ic/smc83c170.c | 5 | ||||
| -rw-r--r-- | sys/dev/usb/if_aue.c | 7 | ||||
| -rw-r--r-- | sys/dev/usb/if_udav.c | 5 | ||||
| -rw-r--r-- | sys/dev/usb/if_url.c | 5 |
4 files changed, 9 insertions, 13 deletions
diff --git a/sys/dev/ic/smc83c170.c b/sys/dev/ic/smc83c170.c index c8e27bd5535..8811dd95783 100644 --- a/sys/dev/ic/smc83c170.c +++ b/sys/dev/ic/smc83c170.c @@ -1,4 +1,4 @@ -/* $OpenBSD: smc83c170.c,v 1.27 2017/01/22 10:17:38 dlg Exp $ */ +/* $OpenBSD: smc83c170.c,v 1.28 2018/07/03 14:33:43 kevlo Exp $ */ /* $NetBSD: smc83c170.c,v 1.59 2005/02/27 00:27:02 perry Exp $ */ /*- @@ -1443,8 +1443,7 @@ epic_mediachange(struct ifnet *ifp) } /* Lookup selected PHY */ - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL; - miisc = LIST_NEXT(miisc, mii_list)) { + LIST_FOREACH(miisc, &mii->mii_phys, mii_list) { if (IFM_INST(media) == miisc->mii_inst) break; } diff --git a/sys/dev/usb/if_aue.c b/sys/dev/usb/if_aue.c index e508a95dd8b..83c9043f305 100644 --- a/sys/dev/usb/if_aue.c +++ b/sys/dev/usb/if_aue.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_aue.c,v 1.107 2018/07/03 00:49:14 kevlo Exp $ */ +/* $OpenBSD: if_aue.c,v 1.108 2018/07/03 14:33:43 kevlo Exp $ */ /* $NetBSD: if_aue.c,v 1.82 2003/03/05 17:37:36 shiba Exp $ */ /* * Copyright (c) 1997, 1998, 1999, 2000 @@ -1396,9 +1396,8 @@ aue_ifmedia_upd(struct ifnet *ifp) sc->aue_link = 0; if (mii->mii_instance) { struct mii_softc *miisc; - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL; - miisc = LIST_NEXT(miisc, mii_list)) - mii_phy_reset(miisc); + LIST_FOREACH(miisc, &mii->mii_phys, mii_list) + mii_phy_reset(miisc); } mii_mediachg(mii); diff --git a/sys/dev/usb/if_udav.c b/sys/dev/usb/if_udav.c index b68cf5c1cab..1ccab331e64 100644 --- a/sys/dev/usb/if_udav.c +++ b/sys/dev/usb/if_udav.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_udav.c,v 1.79 2017/01/22 10:17:39 dlg Exp $ */ +/* $OpenBSD: if_udav.c,v 1.80 2018/07/03 14:33:43 kevlo Exp $ */ /* $NetBSD: if_udav.c,v 1.3 2004/04/23 17:25:25 itojun Exp $ */ /* $nabe: if_udav.c,v 1.3 2003/08/21 16:57:19 nabe Exp $ */ /* @@ -1303,8 +1303,7 @@ udav_ifmedia_change(struct ifnet *ifp) if (mii->mii_instance) { struct mii_softc *miisc; - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL; - miisc = LIST_NEXT(miisc, mii_list)) + LIST_FOREACH(miisc, &mii->mii_phys, mii_list) mii_phy_reset(miisc); } diff --git a/sys/dev/usb/if_url.c b/sys/dev/usb/if_url.c index 1158788930e..5438c41c540 100644 --- a/sys/dev/usb/if_url.c +++ b/sys/dev/usb/if_url.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_url.c,v 1.82 2017/01/22 10:17:39 dlg Exp $ */ +/* $OpenBSD: if_url.c,v 1.83 2018/07/03 14:33:43 kevlo Exp $ */ /* $NetBSD: if_url.c,v 1.6 2002/09/29 10:19:21 martin Exp $ */ /* * Copyright (c) 2001, 2002 @@ -1160,8 +1160,7 @@ url_ifmedia_change(struct ifnet *ifp) sc->sc_link = 0; if (mii->mii_instance) { struct mii_softc *miisc; - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL; - miisc = LIST_NEXT(miisc, mii_list)) + LIST_FOREACH(miisc, &mii->mii_phys, mii_list) mii_phy_reset(miisc); } |