summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorderaadt <deraadt@openbsd.org>2013-04-17 15:33:02 +0000
committerderaadt <deraadt@openbsd.org>2013-04-17 15:33:02 +0000
commit9540f83accb4689be6a213a390b9f11d1555f992 (patch)
tree41b52291d3e11374f0fc59f2eabe180a4512c541
parent(long long) and %lld for big time_t (diff)
downloadwireguard-openbsd-9540f83accb4689be6a213a390b9f11d1555f992.tar.xz
wireguard-openbsd-9540f83accb4689be6a213a390b9f11d1555f992.zip
evtag_marshal_timeval() truncates tv_sec to 32 bits, not passing the high
bits. Mark it with XXX 2038. I think it is poor style to create a "marshalling layer" which throws away information someone might need. ok nicm, who will pass the news upstream and ask for them to fix it
-rw-r--r--lib/libevent/event_tagging.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/libevent/event_tagging.c b/lib/libevent/event_tagging.c
index 9090557af34..90b18824ab3 100644
--- a/lib/libevent/event_tagging.c
+++ b/lib/libevent/event_tagging.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: event_tagging.c,v 1.3 2010/04/21 20:02:40 nicm Exp $ */
+/* $OpenBSD: event_tagging.c,v 1.4 2013/04/17 15:33:02 deraadt Exp $ */
/*
* Copyright (c) 2003, 2004 Niels Provos <provos@citi.umich.edu>
@@ -218,7 +218,7 @@ evtag_marshal_timeval(struct evbuffer *evbuf, ev_uint32_t tag, struct timeval *t
{
evbuffer_drain(_buf, EVBUFFER_LENGTH(_buf));
- encode_int(_buf, tv->tv_sec);
+ encode_int(_buf, tv->tv_sec); /* XXX 2038 */
encode_int(_buf, tv->tv_usec);
evtag_marshal(evbuf, tag, EVBUFFER_DATA(_buf),