diff options
| author |   miod <miod@openbsd.org> | 2014-06-27 22:02:07 +0000 |
|---|---|---|
| committer | miod <miod@openbsd.org> | 2014-06-27 22:02:07 +0000 |
| commit | aed1efb5d2f43aa8f5f796a2669bfcc119e2b24e (patch) | |
| tree | 411cf9d688bf173109425aa855e9ce1b0d0ba724 | |
| parent | re-init and init code paths are now more shared, so the getpid()-based (diff) | |
| download | wireguard-openbsd-aed1efb5d2f43aa8f5f796a2669bfcc119e2b24e.tar.xz wireguard-openbsd-aed1efb5d2f43aa8f5f796a2669bfcc119e2b24e.zip | |
When building a BN on the stack in BN_div(), make sure to initialize all its
fields (i.e. the flags field) before using it. This is currently harmless,
but might not be if we end up invoking other BN functions checking for
constant-time processing requirement in the future.
| -rw-r--r-- | lib/libcrypto/bn/bn_div.c | 3 | ||||
| -rw-r--r-- | lib/libssl/src/crypto/bn/bn_div.c | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/lib/libcrypto/bn/bn_div.c b/lib/libcrypto/bn/bn_div.c index 3774a636118..2f45a412b46 100644 --- a/lib/libcrypto/bn/bn_div.c +++ b/lib/libcrypto/bn/bn_div.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_div.c,v 1.19 2014/06/12 15:49:28 deraadt Exp $ */ +/* $OpenBSD: bn_div.c,v 1.20 2014/06/27 22:02:07 miod Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -209,6 +209,7 @@ BN_div(BIGNUM *dv, BIGNUM *rm, const BIGNUM *num, const BIGNUM *divisor, wnum.top = div_n; /* only needed when BN_ucmp messes up the values between top and max */ wnum.dmax = snum->dmax - loop; /* so we don't step out of bounds */ + wnum.flags = snum->flags | BN_FLG_STATIC_DATA; /* Get the top 2 words of sdiv */ /* div_n=sdiv->top; */ diff --git a/lib/libssl/src/crypto/bn/bn_div.c b/lib/libssl/src/crypto/bn/bn_div.c index 3774a636118..2f45a412b46 100644 --- a/lib/libssl/src/crypto/bn/bn_div.c +++ b/lib/libssl/src/crypto/bn/bn_div.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_div.c,v 1.19 2014/06/12 15:49:28 deraadt Exp $ */ +/* $OpenBSD: bn_div.c,v 1.20 2014/06/27 22:02:07 miod Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -209,6 +209,7 @@ BN_div(BIGNUM *dv, BIGNUM *rm, const BIGNUM *num, const BIGNUM *divisor, wnum.top = div_n; /* only needed when BN_ucmp messes up the values between top and max */ wnum.dmax = snum->dmax - loop; /* so we don't step out of bounds */ + wnum.flags = snum->flags | BN_FLG_STATIC_DATA; /* Get the top 2 words of sdiv */ /* div_n=sdiv->top; */ |