diff options
| author |   aoyama <aoyama@openbsd.org> | 2017-03-15 11:13:34 +0000 |
|---|---|---|
| committer | aoyama <aoyama@openbsd.org> | 2017-03-15 11:13:34 +0000 |
| commit | c368aea8a4eedb9808a10b3e1fa6b8a4f71e8629 (patch) | |
| tree | da057ddaa803565b36681893702963ba35980cad | |
| parent | It's annoying that people keep writing URIs including redundant parts (diff) | |
| download | wireguard-openbsd-c368aea8a4eedb9808a10b3e1fa6b8a4f71e8629.tar.xz wireguard-openbsd-c368aea8a4eedb9808a10b3e1fa6b8a4f71e8629.zip | |
We do not need while loop around uiomove(9) in lcdwrite().
Pointed out by Enami Tsugutomo while porting this driver to NetBSD/luna68k
by Izumi Tsutsui.
Tested by me.
| -rw-r--r-- | sys/arch/luna88k/dev/lcd.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/sys/arch/luna88k/dev/lcd.c b/sys/arch/luna88k/dev/lcd.c index bec431b990d..086a859ff72 100644 --- a/sys/arch/luna88k/dev/lcd.c +++ b/sys/arch/luna88k/dev/lcd.c @@ -1,4 +1,4 @@ -/* $OpenBSD: lcd.c,v 1.7 2015/02/10 22:42:35 miod Exp $ */ +/* $OpenBSD: lcd.c,v 1.8 2017/03/15 11:13:34 aoyama Exp $ */ /* $NetBSD: lcd.c,v 1.2 2000/01/07 05:13:08 nisimura Exp $ */ /*- @@ -163,21 +163,17 @@ int lcdwrite(dev_t dev, struct uio *uio, int flag) { int error; - size_t len; - size_t i, n; + size_t len, i; char buf[LCD_MAXBUFLEN]; - len = n = uio->uio_resid; + len = uio->uio_resid; if (len > LCD_MAXBUFLEN) return EIO; - while (n > 0) { - error = uiomove(buf, n, uio); - if (error) - return EIO; - n = uio->uio_resid; - } + error = uiomove(buf, len, uio); + if (error) + return EIO; for (i = 0; i < len; i++) { lcdput((int)buf[i]); |