diff options
| author |   jsg <jsg@openbsd.org> | 2015-09-05 09:47:08 +0000 |
|---|---|---|
| committer | jsg <jsg@openbsd.org> | 2015-09-05 09:47:08 +0000 |
| commit | d927f21f9c49cae2570fbd60317d0bf7ded5b7dc (patch) | |
| tree | 8094217350101d23feeb73f526a01abb9cb93023 | |
| parent | Avoid unintended problems with operator precedence when doing an (diff) | |
| download | wireguard-openbsd-d927f21f9c49cae2570fbd60317d0bf7ded5b7dc.tar.xz wireguard-openbsd-d927f21f9c49cae2570fbd60317d0bf7ded5b7dc.zip | |
Add brackets to clarify assignments that are the result of a test operator.
ok deraadt@ looks correct millert@ jung@
| -rw-r--r-- | bin/ksh/path.c | 4 | ||||
| -rw-r--r-- | usr.bin/cvs/diff3.c | 4 | ||||
| -rw-r--r-- | usr.bin/diff3/diff3prog.c | 4 | ||||
| -rw-r--r-- | usr.bin/rcs/diff3.c | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/bin/ksh/path.c b/bin/ksh/path.c index f20823faab4..a6973724bb2 100644 --- a/bin/ksh/path.c +++ b/bin/ksh/path.c @@ -1,4 +1,4 @@ -/* $OpenBSD: path.c,v 1.12 2005/03/30 17:16:37 deraadt Exp $ */ +/* $OpenBSD: path.c,v 1.13 2015/09/05 09:47:08 jsg Exp $ */ #include "sh.h" #include <sys/stat.h> @@ -116,7 +116,7 @@ simplify_path(char *path) if (!*path) return; - if ((isrooted = path[0] == '/')) + if ((isrooted = (path[0] == '/'))) very_start++; /* Before After diff --git a/usr.bin/cvs/diff3.c b/usr.bin/cvs/diff3.c index a15248a1bb7..3a601e430d0 100644 --- a/usr.bin/cvs/diff3.c +++ b/usr.bin/cvs/diff3.c @@ -1,4 +1,4 @@ -/* $OpenBSD: diff3.c,v 1.57 2015/01/16 06:40:07 deraadt Exp $ */ +/* $OpenBSD: diff3.c,v 1.58 2015/09/05 09:47:08 jsg Exp $ */ /* * Copyright (C) Caldera International Inc. 2001-2002. @@ -548,7 +548,7 @@ merge(size_t m1, size_t m2) d1 = d13; d2 = d23; j = 0; - while ((t1 = d1 < d13 + m1) | (t2 = d2 < d23 + m2)) { + while ((t1 = (d1 < d13 + m1)) | (t2 = (d2 < d23 + m2))) { if (debug) { printf("%d,%d=%d,%d %d,%d=%d,%d\n", d1->old.from, d1->old.to, diff --git a/usr.bin/diff3/diff3prog.c b/usr.bin/diff3/diff3prog.c index 94d5410dfe1..86d836e59d5 100644 --- a/usr.bin/diff3/diff3prog.c +++ b/usr.bin/diff3/diff3prog.c @@ -1,4 +1,4 @@ -/* $OpenBSD: diff3prog.c,v 1.14 2014/12/01 06:36:32 deraadt Exp $ */ +/* $OpenBSD: diff3prog.c,v 1.15 2015/09/05 09:47:08 jsg Exp $ */ /* * Copyright (C) Caldera International Inc. 2001-2002. @@ -298,7 +298,7 @@ merge(int m1, int m2) d1 = d13; d2 = d23; j = 0; - while ((t1 = d1 < d13 + m1) | (t2 = d2 < d23 + m2)) { + while ((t1 = (d1 < d13 + m1)) | (t2 = (d2 < d23 + m2))) { if (debug) { printf("%d,%d=%d,%d %d,%d=%d,%d\n", d1->old.from,d1->old.to, diff --git a/usr.bin/rcs/diff3.c b/usr.bin/rcs/diff3.c index 39c37e6ad79..ab1964e431e 100644 --- a/usr.bin/rcs/diff3.c +++ b/usr.bin/rcs/diff3.c @@ -1,4 +1,4 @@ -/* $OpenBSD: diff3.c,v 1.36 2015/06/13 20:15:21 nicm Exp $ */ +/* $OpenBSD: diff3.c,v 1.37 2015/09/05 09:47:08 jsg Exp $ */ /* * Copyright (C) Caldera International Inc. 2001-2002. @@ -643,7 +643,7 @@ merge(size_t m1, size_t m2) d1 = d13; d2 = d23; j = 0; - while ((t1 = d1 < d13 + m1) | (t2 = d2 < d23 + m2)) { + while ((t1 = (d1 < d13 + m1)) | (t2 = (d2 < d23 + m2))) { if (debug) { printf("%d,%d=%d,%d %d,%d=%d,%d\n", d1->old.from, d1->old.to, |