diff options
| author |   mmcc <mmcc@openbsd.org> | 2015-12-21 20:52:33 +0000 |
|---|---|---|
| committer | mmcc <mmcc@openbsd.org> | 2015-12-21 20:52:33 +0000 |
| commit | ddc17c47f5384d216941589a0840ae88b4d078cc (patch) | |
| tree | 2f1cae368bd88d6ba606d5f5a7d6ff92eef2a498 | |
| parent | Introduce xen_intr_mask and xen_intr_unmask primitives (diff) | |
| download | wireguard-openbsd-ddc17c47f5384d216941589a0840ae88b4d078cc.tar.xz wireguard-openbsd-ddc17c47f5384d216941589a0840ae88b4d078cc.zip | |
Goto a loop_end label rather than using a continue statement for an
error condition in an inner loop. Found with Coccinelle.
Pointed out by tedu@, ok kettenis@ and deraadt@ about three months ago.
| -rw-r--r-- | sys/dev/pci/pciide.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sys/dev/pci/pciide.c b/sys/dev/pci/pciide.c index e9fc9b01fd0..094adde744c 100644 --- a/sys/dev/pci/pciide.c +++ b/sys/dev/pci/pciide.c @@ -1,4 +1,4 @@ -/* $OpenBSD: pciide.c,v 1.356 2015/11/24 11:24:21 mpi Exp $ */ +/* $OpenBSD: pciide.c,v 1.357 2015/12/21 20:52:33 mmcc Exp $ */ /* $NetBSD: pciide.c,v 1.127 2001/08/03 01:31:08 tsutsui Exp $ */ /* @@ -6976,7 +6976,7 @@ pdcsata_chip_map(struct pciide_softc *sc, struct pci_attach_args *pa) "regs\n", sc->sc_wdcdev.sc_dev.dv_xname, channel); - continue; + goto loop_end; } } ps->regs[channel].cmd_iohs[wdr_status & _WDC_REGMASK] = @@ -7022,6 +7022,8 @@ pdcsata_chip_map(struct pciide_softc *sc, struct pci_attach_args *pa) (channel + 1) << 2, 0x00000001); pdc203xx_setup_channel(&cp->wdc_channel); + +loop_end: ; } printf("%s: using %s for native-PCI interrupt\n", |