diff options
| author |   jfb <jfb@openbsd.org> | 2004-12-16 18:55:52 +0000 |
|---|---|---|
| committer | jfb <jfb@openbsd.org> | 2004-12-16 18:55:52 +0000 |
| commit | e97a4b3a6c69207e4ce04e6da9c67e8f718ec281 (patch) | |
| tree | a0903e2d32027dd38d7421f863ed332a496013f9 | |
| parent | Add rcs_gethead() to easily retrieve the head revision of an RCS (diff) | |
| download | wireguard-openbsd-e97a4b3a6c69207e4ce04e6da9c67e8f718ec281.tar.xz wireguard-openbsd-e97a4b3a6c69207e4ce04e6da9c67e8f718ec281.zip | |
plug some memory leaks on error cases
| -rw-r--r-- | usr.bin/cvs/rcs.c | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/usr.bin/cvs/rcs.c b/usr.bin/cvs/rcs.c index 7dc2ddcf7f8..b6e8bb73c97 100644 --- a/usr.bin/cvs/rcs.c +++ b/usr.bin/cvs/rcs.c @@ -1,4 +1,4 @@ -/* $OpenBSD: rcs.c,v 1.16 2004/12/16 17:16:18 jfb Exp $ */ +/* $OpenBSD: rcs.c,v 1.17 2004/12/16 18:55:52 jfb Exp $ */ /* * Copyright (c) 2004 Jean-Francois Brousseau <jfb@openbsd.org> * All rights reserved. @@ -381,6 +381,8 @@ rcs_addsym(RCSFILE *rfp, const char *sym, RCSNUM *snum) /* first look for duplication */ TAILQ_FOREACH(symp, &(rfp->rf_symbols), rs_list) { if (strcmp(symp->rs_name, sym) == 0) { + cvs_log(LP_ERR, "attempt to add duplicate symbol `%s'", + sym); return (-1); } } @@ -400,6 +402,7 @@ rcs_addsym(RCSFILE *rfp, const char *sym, RCSNUM *snum) symp->rs_num = rcsnum_alloc(); if (symp->rs_num == NULL) { + free(symp->rs_name); free(symp); return (-1); } @@ -437,16 +440,20 @@ rcs_patch(const char *data, const char *patch) return (NULL); dlines = rcs_splitlines(data); - if (dlines == NULL) + if (dlines == NULL) { + cvs_buf_free(res); return (NULL); + } plines = rcs_splitlines(patch); if (plines == NULL) { + cvs_buf_free(res); rcs_freefoo(dlines); return (NULL); } if (rcs_patch_lines(dlines, plines) < 0) { + cvs_buf_free(res); rcs_freefoo(plines); rcs_freefoo(dlines); return (NULL); @@ -598,14 +605,19 @@ rcs_getrev(RCSFILE *rfp, RCSNUM *rev) * This will need some rework to support sub branches. */ crev = rcsnum_alloc(); - if (crev == NULL) + if (crev == NULL) { + cvs_buf_free(rbuf); return (NULL); + } rcsnum_cpy(rfp->rf_head, crev, 0); do { crev->rn_id[crev->rn_len - 1]--; rdp = rcs_findrev(rfp, crev); - if (rdp == NULL) + if (rdp == NULL) { + rcsnum_free(crev); + cvs_buf_free(rbuf); return (NULL); + } cvs_buf_putc(rbuf, '\0'); bp = cvs_buf_release(rbuf); @@ -618,7 +630,6 @@ rcs_getrev(RCSFILE *rfp, RCSNUM *rev) } } - return (rbuf); } |