diff options
| author |   visa <visa@openbsd.org> | 2020-06-14 07:22:55 +0000 |
|---|---|---|
| committer | visa <visa@openbsd.org> | 2020-06-14 07:22:55 +0000 |
| commit | efd4ef097cf73b798bd1f1367949c93c305e2102 (patch) | |
| tree | 3f0cf468da1a6bad759e67eb1ba5ec2cb52cab28 | |
| parent | make IS_ERR() and IS_ERR_OR_NULL() return bool (diff) | |
| download | wireguard-openbsd-efd4ef097cf73b798bd1f1367949c93c305e2102.tar.xz wireguard-openbsd-efd4ef097cf73b798bd1f1367949c93c305e2102.zip | |
Remove misleading XXX about locking of ps_klist. All of the kqueue
subsystem and ps_klist handling still run under the kernel lock.
| -rw-r--r-- | sys/kern/kern_event.c | 4 | ||||
| -rw-r--r-- | sys/kern/kern_sig.c | 3 |
2 files changed, 2 insertions, 5 deletions
diff --git a/sys/kern/kern_event.c b/sys/kern/kern_event.c index bafc8f11418..bb1340da842 100644 --- a/sys/kern/kern_event.c +++ b/sys/kern/kern_event.c @@ -1,4 +1,4 @@ -/* $OpenBSD: kern_event.c,v 1.136 2020/06/12 09:34:17 mpi Exp $ */ +/* $OpenBSD: kern_event.c,v 1.137 2020/06/14 07:22:55 visa Exp $ */ /*- * Copyright (c) 1999,2000,2001 Jonathan Lemon <jlemon@FreeBSD.org> @@ -274,7 +274,6 @@ filt_procattach(struct knote *kn) kn->kn_flags &= ~EV_FLAG1; } - /* XXX lock the proc here while adding to the list? */ klist_insert(&pr->ps_klist, kn); return (0); @@ -296,7 +295,6 @@ filt_procdetach(struct knote *kn) if (kn->kn_status & KN_DETACHED) return; - /* XXX locking? this might modify another process. */ klist_remove(&pr->ps_klist, kn); } diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index ba9f425a705..76ebe1cc68d 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -1,4 +1,4 @@ -/* $OpenBSD: kern_sig.c,v 1.256 2020/04/07 13:27:51 visa Exp $ */ +/* $OpenBSD: kern_sig.c,v 1.257 2020/06/14 07:22:55 visa Exp $ */ /* $NetBSD: kern_sig.c,v 1.54 1996/04/22 01:38:32 christos Exp $ */ /* @@ -1810,7 +1810,6 @@ filt_sigattach(struct knote *kn) kn->kn_ptr.p_process = pr; kn->kn_flags |= EV_CLEAR; /* automatically set */ - /* XXX lock the proc here while adding to the list? */ klist_insert(&pr->ps_klist, kn); return (0); |