diff options
| author |   tedu <tedu@openbsd.org> | 2003-04-08 19:55:52 +0000 |
|---|---|---|
| committer | tedu <tedu@openbsd.org> | 2003-04-08 19:55:52 +0000 |
| commit | f924ca9922af06e7550314b58ff995a734d1e285 (patch) | |
| tree | f05ba970aaf062e2372ca6507d3586fff0621204 | |
| parent | string fixes in code we don't compile by default; tedu help & ok (diff) | |
| download | wireguard-openbsd-f924ca9922af06e7550314b58ff995a734d1e285.tar.xz wireguard-openbsd-f924ca9922af06e7550314b58ff995a734d1e285.zip | |
more correct snprintf bound. ok deraadt@
| -rw-r--r-- | usr.sbin/ppp/ppp/chap.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/usr.sbin/ppp/ppp/chap.c b/usr.sbin/ppp/ppp/chap.c index f1d8b3c41cb..0e56d899b48 100644 --- a/usr.sbin/ppp/ppp/chap.c +++ b/usr.sbin/ppp/ppp/chap.c @@ -25,7 +25,7 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $OpenBSD: chap.c,v 1.38 2003/04/07 23:58:53 deraadt Exp $ + * $OpenBSD: chap.c,v 1.39 2003/04/08 19:55:52 tedu Exp $ */ #include <sys/param.h> @@ -605,8 +605,10 @@ chap_Failure(struct authinfo *authp) snprintf(buf, sizeof(buf), "E=691 R=0 C="); ptr += strlen(ptr); for (i=0; i<16; i++) { - snprintf(ptr, 3, "%02X", *(auth2chap(authp)->challenge.local+1+i)); + snprintf(ptr, buf + sizeof buf - ptr, "%02X", *(auth2chap(authp)->challenge.local+1+i)); ptr += strlen(ptr); + if (ptr > buf + sizeof buf) + break; } snprintf(ptr, buf + sizeof buf - ptr, " V=3 M=Invalid!"); |