diff options
| author |   deraadt <deraadt@openbsd.org> | 2019-03-24 17:56:54 +0000 |
|---|---|---|
| committer | deraadt <deraadt@openbsd.org> | 2019-03-24 17:56:54 +0000 |
| commit | 1bdfaae350f1b705d43796cc6dd7d5829cbfe294 (patch) | |
| tree | f0726d00c723a94ac69be1b1a42e8cc935dd6442 /lib/libc | |
| parent | Reduce debug logging in best_resolver() to two lines, helps a bit with (diff) | |
| download | wireguard-openbsd-1bdfaae350f1b705d43796cc6dd7d5829cbfe294.tar.xz wireguard-openbsd-1bdfaae350f1b705d43796cc6dd7d5829cbfe294.zip | |
In the incredibly unbelievable circumstance where _rs_init() fails to
allocate pages, don't call abort() because of corefile data leakage
concerns, but simply _exit(). The reasoning is _rs_init() will only
fail if someone finds a way to apply specific pressure against this
failure point, for the purpose of leaking information into a core which
they can read. We don't need a corefile in this instance to debug that.
So take this "lever" away from whoever in the future wants to do that.
Diffstat (limited to 'lib/libc')
| -rw-r--r-- | lib/libc/crypt/arc4random.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/libc/crypt/arc4random.c b/lib/libc/crypt/arc4random.c index 8a4ecc9e893..1a16bd3940b 100644 --- a/lib/libc/crypt/arc4random.c +++ b/lib/libc/crypt/arc4random.c @@ -1,4 +1,4 @@ -/* $OpenBSD: arc4random.c,v 1.54 2015/09/13 08:31:47 guenther Exp $ */ +/* $OpenBSD: arc4random.c,v 1.55 2019/03/24 17:56:54 deraadt Exp $ */ /* * Copyright (c) 1996, David Mazieres <dm@uun.org> @@ -75,7 +75,7 @@ _rs_init(u_char *buf, size_t n) if (rs == NULL) { if (_rs_allocate(&rs, &rsx) == -1) - abort(); + _exit(1); } chacha_keysetup(&rsx->rs_chacha, buf, KEYSZ * 8, 0); |