diff options
| author |   tedu <tedu@openbsd.org> | 2014-04-23 20:22:37 +0000 |
|---|---|---|
| committer | tedu <tedu@openbsd.org> | 2014-04-23 20:22:37 +0000 |
| commit | 282e04bd98988b7a74395257b01960e3432d87da (patch) | |
| tree | ea0c281c32dbc5229cfdb262e267fde43188a2c5 /lib/libssl/src | |
| parent | if realloc failed, BIO_accept would leak memory and return NULL, causing (diff) | |
| download | wireguard-openbsd-282e04bd98988b7a74395257b01960e3432d87da.tar.xz wireguard-openbsd-282e04bd98988b7a74395257b01960e3432d87da.zip | |
close socket in failure cases too
Diffstat (limited to 'lib/libssl/src')
| -rw-r--r-- | lib/libssl/src/crypto/bio/b_sock.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/libssl/src/crypto/bio/b_sock.c b/lib/libssl/src/crypto/bio/b_sock.c index a7791b39e2e..e5f42398df6 100644 --- a/lib/libssl/src/crypto/bio/b_sock.c +++ b/lib/libssl/src/crypto/bio/b_sock.c @@ -535,6 +535,7 @@ BIO_accept(int sock, char **addr) if (p) { *p = '\0'; if (!(tmp = realloc(p, nl))) { + close(ret); ret = -1; free(p); *addr = NULL; @@ -546,6 +547,7 @@ BIO_accept(int sock, char **addr) p = malloc(nl); } if (p == NULL) { + close(ret); ret = -1; BIOerr(BIO_F_BIO_ACCEPT, ERR_R_MALLOC_FAILURE); goto end; @@ -561,6 +563,7 @@ BIO_accept(int sock, char **addr) port = ntohs(sa.from.sa_in.sin_port); if (*addr == NULL) { if ((p = malloc(24)) == NULL) { + close(ret); ret = -1; BIOerr(BIO_F_BIO_ACCEPT, ERR_R_MALLOC_FAILURE); goto end; |