diff options
| author |   tedu <tedu@openbsd.org> | 2014-04-08 14:20:01 +0000 |
|---|---|---|
| committer | tedu <tedu@openbsd.org> | 2014-04-08 14:20:01 +0000 |
| commit | 7fb87b8738a714a078e3d0c4f6bb8612ba45f4fc (patch) | |
| tree | 1ff2855b3507ff712b61e089d195ae27b0af1ba3 /lib/libutil | |
| parent | Use VM_UVMEXP instead of VM_METER for memory usages and directly (diff) | |
| download | wireguard-openbsd-7fb87b8738a714a078e3d0c4f6bb8612ba45f4fc.tar.xz wireguard-openbsd-7fb87b8738a714a078e3d0c4f6bb8612ba45f4fc.zip | |
fix an error in the stride calculations. the math only works for multiples
of the stride. don't overwrite past the end of the buffer, and also save
that amount for later so the array is completely filled. ok deraadt djm
reported by Dmitry Chestnykh (dchest)
Diffstat (limited to 'lib/libutil')
| -rw-r--r-- | lib/libutil/bcrypt_pbkdf.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/libutil/bcrypt_pbkdf.c b/lib/libutil/bcrypt_pbkdf.c index 22725e69788..8275b66b9e6 100644 --- a/lib/libutil/bcrypt_pbkdf.c +++ b/lib/libutil/bcrypt_pbkdf.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bcrypt_pbkdf.c,v 1.6 2014/01/31 16:56:32 tedu Exp $ */ +/* $OpenBSD: bcrypt_pbkdf.c,v 1.7 2014/04/08 14:20:01 tedu Exp $ */ /* * Copyright (c) 2013 Ted Unangst <tedu@openbsd.org> * @@ -104,6 +104,7 @@ bcrypt_pbkdf(const char *pass, size_t passlen, const uint8_t *salt, size_t saltl uint8_t countsalt[4]; size_t i, j, amt, stride; uint32_t count; + size_t origkeylen = keylen; /* nothing crazy */ if (rounds < 1) @@ -149,9 +150,13 @@ bcrypt_pbkdf(const char *pass, size_t passlen, const uint8_t *salt, size_t saltl * pbkdf2 deviation: ouput the key material non-linearly. */ amt = MIN(amt, keylen); - for (i = 0; i < amt; i++) - key[i * stride + (count - 1)] = out[i]; - keylen -= amt; + for (i = 0; i < amt; i++) { + size_t dest = i * stride + (count - 1); + if (dest >= origkeylen) + break; + key[dest] = out[i]; + } + keylen -= i; } /* zap */ |