diff options
| author |   millert <millert@openbsd.org> | 2000-06-30 16:00:03 +0000 |
|---|---|---|
| committer | millert <millert@openbsd.org> | 2000-06-30 16:00:03 +0000 |
| commit | b638aa94715d7c4b461552b23f350ea53e1afd5a (patch) | |
| tree | aa7fbc4972a0b2e67a2a10a222aefffd0c85c9a5 /lib/libutil | |
| parent | My previous two attempts at fixing the "scrolling region" problem were wrong. (diff) | |
| download | wireguard-openbsd-b638aa94715d7c4b461552b23f350ea53e1afd5a.tar.xz wireguard-openbsd-b638aa94715d7c4b461552b23f350ea53e1afd5a.zip | |
warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).
Diffstat (limited to 'lib/libutil')
| -rw-r--r-- | lib/libutil/passwd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/libutil/passwd.c b/lib/libutil/passwd.c index 456f878cc99..5de35e97e5d 100644 --- a/lib/libutil/passwd.c +++ b/lib/libutil/passwd.c @@ -1,4 +1,4 @@ -/* $OpenBSD: passwd.c,v 1.20 1998/11/16 07:10:32 deraadt Exp $ */ +/* $OpenBSD: passwd.c,v 1.21 2000/06/30 16:00:07 millert Exp $ */ /* * Copyright (c) 1987, 1993, 1994, 1995 @@ -34,7 +34,7 @@ */ #if defined(LIBC_SCCS) && !defined(lint) -static char rcsid[] = "$OpenBSD: passwd.c,v 1.20 1998/11/16 07:10:32 deraadt Exp $"; +static char rcsid[] = "$OpenBSD: passwd.c,v 1.21 2000/06/30 16:00:07 millert Exp $"; #endif /* LIBC_SCCS and not lint */ #include <sys/types.h> @@ -579,7 +579,7 @@ pw_error(name, err, eval) char *master = pw_file(_PATH_MASTERPASSWD); if (err) - warn(name); + warn("%s", name); if (master) warnx("%s: unchanged", master); pw_abort(); |