No need to bzero()/memset() 'struct scsibus_attach_args' variables

immediately before initializing the only field in the struct.

23 files changed, 23 insertions, 48 deletions

diff --git a/sys/dev/ic/aac.c b/sys/dev/ic/aac.c
index 08dcd1e16c4..3347b146c8a 100644
--- a/sys/dev/ic/aac.c
+++ b/sys/dev/ic/aac.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: aac.c,v 1.78 2020/06/24 22:03:41 cheloha Exp $	*/
+/*	$OpenBSD: aac.c,v 1.79 2020/06/27 14:29:44 krw Exp $	*/
 
 /*-
  * Copyright (c) 2000 Michael Smith
@@ -275,7 +275,6 @@ aac_attach(struct aac_softc *sc)
 	sc->aac_link.adapter_target = SDEV_NO_ADAPTER_TARGET;
 	sc->aac_link.pool = &sc->aac_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->aac_link;
 
 	config_found(&sc->aac_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/adv.c b/sys/dev/ic/adv.c
index 20ecfac4274..225e7b1224f 100644
--- a/sys/dev/ic/adv.c
+++ b/sys/dev/ic/adv.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: adv.c,v 1.42 2020/02/15 18:02:00 krw Exp $	*/
+/*	$OpenBSD: adv.c,v 1.43 2020/06/27 14:29:44 krw Exp $	*/
 /*	$NetBSD: adv.c,v 1.6 1998/10/28 20:39:45 dante Exp $	*/
 
 /*
@@ -509,7 +509,6 @@ adv_attach(sc)
 		       sc->sc_dev.dv_xname, i, ADV_MAX_CCB);
 	}
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 	config_found(&sc->sc_dev, &saa, scsiprint);
 }
diff --git a/sys/dev/ic/adw.c b/sys/dev/ic/adw.c
index 29e65855b04..51866fd9c6a 100644
--- a/sys/dev/ic/adw.c
+++ b/sys/dev/ic/adw.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: adw.c,v 1.61 2020/03/10 22:31:36 krw Exp $ */
+/*	$OpenBSD: adw.c,v 1.62 2020/06/27 14:29:44 krw Exp $ */
 /* $NetBSD: adw.c,v 1.23 2000/05/27 18:24:50 dante Exp $	 */
 
 /*
@@ -512,7 +512,6 @@ adw_attach(ADW_SOFTC *sc)
 	sc->sc_link.adapter_buswidth = ADW_MAX_TID+1;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/aic6250.c b/sys/dev/ic/aic6250.c
index 5853b47714c..23defd29534 100644
--- a/sys/dev/ic/aic6250.c
+++ b/sys/dev/ic/aic6250.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: aic6250.c,v 1.7 2020/02/05 16:29:29 krw Exp $	*/
+/*	$OpenBSD: aic6250.c,v 1.8 2020/06/27 14:29:44 krw Exp $	*/
 
 /*
  * Copyright (c) 2010, 2013 Miodrag Vallat.
@@ -211,7 +211,6 @@ aic6250_attach(struct aic6250_softc *sc)
 	sc->sc_link.openings = 2;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/aic6360.c b/sys/dev/ic/aic6360.c
index b04ba119cc4..fdaac14765f 100644
--- a/sys/dev/ic/aic6360.c
+++ b/sys/dev/ic/aic6360.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: aic6360.c,v 1.31 2020/02/05 16:29:29 krw Exp $	*/
+/*	$OpenBSD: aic6360.c,v 1.32 2020/06/27 14:29:44 krw Exp $	*/
 /*	$NetBSD: aic6360.c,v 1.52 1996/12/10 21:27:51 thorpej Exp $	*/
 
 #ifdef DDB
@@ -272,7 +272,6 @@ aicattach(struct aic_softc *sc)
 	sc->sc_link.openings = 2;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/aic79xx_openbsd.c b/sys/dev/ic/aic79xx_openbsd.c
index 95be685f6f8..466bf17ce62 100644
--- a/sys/dev/ic/aic79xx_openbsd.c
+++ b/sys/dev/ic/aic79xx_openbsd.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: aic79xx_openbsd.c,v 1.50 2020/02/15 18:02:00 krw Exp $	*/
+/*	$OpenBSD: aic79xx_openbsd.c,v 1.51 2020/06/27 14:29:44 krw Exp $	*/
 
 /*
  * Copyright (c) 2004 Milos Urbanek, Kenneth R. Westerback & Marco Peereboom
@@ -120,7 +120,6 @@ ahd_attach(struct ahd_softc *ahd)
 	if (ahd->flags & AHD_RESET_BUS_A)
 		ahd_reset_channel(ahd, 'A', TRUE);
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &ahd->sc_channel;
 
 	ahd->sc_child = config_found((void *)&ahd->sc_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/aic7xxx_openbsd.c b/sys/dev/ic/aic7xxx_openbsd.c
index 861464b54bc..4cb920f0d0e 100644
--- a/sys/dev/ic/aic7xxx_openbsd.c
+++ b/sys/dev/ic/aic7xxx_openbsd.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: aic7xxx_openbsd.c,v 1.60 2020/02/15 18:02:00 krw Exp $	*/
+/*	$OpenBSD: aic7xxx_openbsd.c,v 1.61 2020/06/27 14:29:44 krw Exp $	*/
 /*	$NetBSD: aic7xxx_osm.c,v 1.14 2003/11/02 11:07:44 wiz Exp $	*/
 
 /*
@@ -107,7 +107,6 @@ ahc_attach(struct ahc_softc *ahc)
 	if ((ahc->features & AHC_TWIN) && ahc->flags & AHC_RESET_BUS_B)
 		ahc_reset_channel(ahc, 'B', TRUE);
 
-	bzero(&saa, sizeof(saa));
 	if ((ahc->flags & AHC_PRIMARY_CHANNEL) == 0) {
 		saa.saa_sc_link = &ahc->sc_channel;
 		ahc->sc_child = config_found((void *)&ahc->sc_dev,
diff --git a/sys/dev/ic/ami.c b/sys/dev/ic/ami.c
index 4430e2afbf7..05950073dc7 100644
--- a/sys/dev/ic/ami.c
+++ b/sys/dev/ic/ami.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ami.c,v 1.242 2020/06/24 18:59:30 krw Exp $	*/
+/*	$OpenBSD: ami.c,v 1.243 2020/06/27 14:29:44 krw Exp $	*/
 
 /*
  * Copyright (c) 2001 Michael Shalayeff
@@ -544,7 +544,6 @@ ami_attach(struct ami_softc *sc)
 	/* lock around ioctl requests */
 	rw_init(&sc->sc_lock, NULL);
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);
@@ -590,7 +589,6 @@ ami_attach(struct ami_softc *sc)
 		rsc->sc_link.adapter_buswidth = 16;
 		rsc->sc_link.pool = &sc->sc_iopool;
 
-		bzero(&saa, sizeof(saa));
 		saa.saa_sc_link = &rsc->sc_link;
 
 		ptbus = (struct scsibus_softc *)config_found(&sc->sc_dev,
diff --git a/sys/dev/ic/cac.c b/sys/dev/ic/cac.c
index 0fd85c90076..e5b0e03b114 100644
--- a/sys/dev/ic/cac.c
+++ b/sys/dev/ic/cac.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: cac.c,v 1.60 2020/06/24 18:59:30 krw Exp $	*/
+/*	$OpenBSD: cac.c,v 1.61 2020/06/27 14:29:45 krw Exp $	*/
 /*	$NetBSD: cac.c,v 1.15 2000/11/08 19:20:35 ad Exp $	*/
 
 /*
@@ -245,7 +245,6 @@ cac_init(struct cac_softc *sc, int startfw)
 		sc->sc_link.openings = 4;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dv, &saa, scsiprint);
diff --git a/sys/dev/ic/ciss.c b/sys/dev/ic/ciss.c
index 529f8bd6dba..8c092d3bf02 100644
--- a/sys/dev/ic/ciss.c
+++ b/sys/dev/ic/ciss.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ciss.c,v 1.82 2020/06/24 18:59:30 krw Exp $	*/
+/*	$OpenBSD: ciss.c,v 1.83 2020/06/27 14:29:45 krw Exp $	*/
 
 /*
  * Copyright (c) 2005,2006 Michael Shalayeff
@@ -360,7 +360,6 @@ ciss_attach(struct ciss_softc *sc)
 	sc->sc_link.adapter_target = SDEV_NO_ADAPTER_TARGET;
 	sc->sc_link.adapter_buswidth = sc->maxunits;
 	sc->sc_link.pool = &sc->sc_iopool;
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 	scsibus = (struct scsibus_softc *)config_found_sm(&sc->sc_dev,
 	    &saa, scsiprint, NULL);
diff --git a/sys/dev/ic/gdt_common.c b/sys/dev/ic/gdt_common.c
index 95ea7744d44..5cbd52d4a9a 100644
--- a/sys/dev/ic/gdt_common.c
+++ b/sys/dev/ic/gdt_common.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: gdt_common.c,v 1.69 2020/06/24 18:47:57 krw Exp $	*/
+/*	$OpenBSD: gdt_common.c,v 1.70 2020/06/27 14:29:45 krw Exp $	*/
 
 /*
  * Copyright (c) 1999, 2000, 2003 Niklas Hallqvist.  All rights reserved.
@@ -476,7 +476,6 @@ gdt_attach(struct gdt_softc *sc)
 #endif
 	gdt_cnt++;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/mfi.c b/sys/dev/ic/mfi.c
index b9df7ba1f75..dc7c17e9c7d 100644
--- a/sys/dev/ic/mfi.c
+++ b/sys/dev/ic/mfi.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: mfi.c,v 1.177 2020/06/24 18:33:50 krw Exp $ */
+/* $OpenBSD: mfi.c,v 1.178 2020/06/27 14:29:45 krw Exp $ */
 /*
  * Copyright (c) 2006 Marco Peereboom <marco@peereboom.us>
  *
@@ -779,7 +779,6 @@ mfi_attach(struct mfi_softc *sc, enum mfi_iop iop)
 	sc->sc_link.openings = sc->sc_max_cmds - 1;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	sc->sc_scsibus = (struct scsibus_softc *)
@@ -855,7 +854,6 @@ mfi_syspd(struct mfi_softc *sc)
 	link->openings = sc->sc_max_cmds - 1;
 	link->pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = link;
 
 	sc->sc_pd->pd_scsibus = (struct scsibus_softc *)
diff --git a/sys/dev/ic/mpi.c b/sys/dev/ic/mpi.c
index d7322b92563..869f56a625e 100644
--- a/sys/dev/ic/mpi.c
+++ b/sys/dev/ic/mpi.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: mpi.c,v 1.213 2020/04/21 19:27:03 krw Exp $ */
+/*	$OpenBSD: mpi.c,v 1.214 2020/06/27 14:29:45 krw Exp $ */
 
 /*
  * Copyright (c) 2005, 2006, 2009 David Gwynne <dlg@openbsd.org>
@@ -363,7 +363,6 @@ mpi_attach(struct mpi_softc *sc)
 	sc->sc_link.openings = MAX(sc->sc_maxcmds / sc->sc_buswidth, 16);
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	memset(&saa, 0, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	/* config_found() returns the scsibus attached to us */
diff --git a/sys/dev/ic/ncr53c9x.c b/sys/dev/ic/ncr53c9x.c
index b15c3b1f9e7..87e7c7e64d0 100644
--- a/sys/dev/ic/ncr53c9x.c
+++ b/sys/dev/ic/ncr53c9x.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ncr53c9x.c,v 1.70 2020/06/24 22:03:41 cheloha Exp $	*/
+/*	$OpenBSD: ncr53c9x.c,v 1.71 2020/06/27 14:29:45 krw Exp $	*/
 /*     $NetBSD: ncr53c9x.c,v 1.56 2000/11/30 14:41:46 thorpej Exp $    */
 
 /*
@@ -271,7 +271,6 @@ ncr53c9x_attach(sc)
 	sc->sc_link.adapter_buswidth = sc->sc_ntarg;
 	sc->sc_link.pool = &ecb_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	/*
diff --git a/sys/dev/ic/nvme.c b/sys/dev/ic/nvme.c
index 818ea7d5aac..43784dabc3f 100644
--- a/sys/dev/ic/nvme.c
+++ b/sys/dev/ic/nvme.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: nvme.c,v 1.75 2020/03/15 20:50:46 krw Exp $ */
+/*	$OpenBSD: nvme.c,v 1.76 2020/06/27 14:29:45 krw Exp $ */
 
 /*
  * Copyright (c) 2014 David Gwynne <dlg@openbsd.org>
@@ -371,7 +371,6 @@ nvme_attach(struct nvme_softc *sc)
 	sc->sc_link.openings = 64;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	memset(&saa, 0, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	sc->sc_scsibus = (struct scsibus_softc *)config_found(&sc->sc_dev,
diff --git a/sys/dev/ic/oosiop.c b/sys/dev/ic/oosiop.c
index defa747b5b6..1b07deb1e93 100644
--- a/sys/dev/ic/oosiop.c
+++ b/sys/dev/ic/oosiop.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: oosiop.c,v 1.26 2020/02/17 02:50:23 krw Exp $	*/
+/*	$OpenBSD: oosiop.c,v 1.27 2020/06/27 14:29:45 krw Exp $	*/
 /*	$NetBSD: oosiop.c,v 1.4 2003/10/29 17:45:55 tsutsui Exp $	*/
 
 /*
@@ -267,7 +267,6 @@ oosiop_attach(struct oosiop_softc *sc)
 	sc->sc_link.pool = &sc->sc_iopool;
 	sc->sc_link.quirks = ADEV_NODOORLOCK;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	/*
diff --git a/sys/dev/ic/osiop.c b/sys/dev/ic/osiop.c
index 835686fa349..8d87771de47 100644
--- a/sys/dev/ic/osiop.c
+++ b/sys/dev/ic/osiop.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: osiop.c,v 1.56 2020/02/17 02:50:23 krw Exp $	*/
+/*	$OpenBSD: osiop.c,v 1.57 2020/06/27 14:29:45 krw Exp $	*/
 /*	$NetBSD: osiop.c,v 1.9 2002/04/05 18:27:54 bouyer Exp $	*/
 
 /*
@@ -334,7 +334,6 @@ osiop_attach(sc)
 	sc->sc_link.adapter_target = sc->sc_id;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	/*
diff --git a/sys/dev/ic/qla.c b/sys/dev/ic/qla.c
index e33265db3af..e46187f405d 100644
--- a/sys/dev/ic/qla.c
+++ b/sys/dev/ic/qla.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: qla.c,v 1.62 2020/06/27 13:36:52 bket Exp $ */
+/*	$OpenBSD: qla.c,v 1.63 2020/06/27 14:29:45 krw Exp $ */
 
 /*
  * Copyright (c) 2011 David Gwynne <dlg@openbsd.org>
@@ -694,7 +694,6 @@ qla_attach(struct qla_softc *sc)
 		sc->sc_link.node_wwn &= ~(0xfULL << 56);
 	}
 
-	memset(&saa, 0, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	/* config_found() returns the scsibus attached to us */
diff --git a/sys/dev/ic/qlw.c b/sys/dev/ic/qlw.c
index 8ba910ff959..ca80e725c5c 100644
--- a/sys/dev/ic/qlw.c
+++ b/sys/dev/ic/qlw.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: qlw.c,v 1.35 2020/06/24 01:35:29 krw Exp $ */
+/*	$OpenBSD: qlw.c,v 1.36 2020/06/27 14:29:45 krw Exp $ */
 
 /*
  * Copyright (c) 2011 David Gwynne <dlg@openbsd.org>
@@ -403,7 +403,6 @@ qlw_attach(struct qlw_softc *sc)
 		sc->sc_link[bus].openings = sc->sc_max_queue_depth[bus];
 		sc->sc_link[bus].pool = &sc->sc_iopool;
 
-		memset(&saa, 0, sizeof(saa));
 		saa.saa_sc_link = &sc->sc_link[bus];
 
 		/* config_found() returns the scsibus attached to us */
diff --git a/sys/dev/ic/siop.c b/sys/dev/ic/siop.c
index 20cd21faa21..032ad2095e9 100644
--- a/sys/dev/ic/siop.c
+++ b/sys/dev/ic/siop.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: siop.c,v 1.75 2020/06/19 14:51:44 krw Exp $ */
+/*	$OpenBSD: siop.c,v 1.76 2020/06/27 14:29:45 krw Exp $ */
 /*	$NetBSD: siop.c,v 1.79 2005/11/18 23:10:32 bouyer Exp $	*/
 
 /*
@@ -213,7 +213,6 @@ siop_attach(sc)
 	siop_dump_script(sc);
 #endif
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_c.sc_link;
 
 	config_found((struct device*)sc, &saa, scsiprint);
diff --git a/sys/dev/ic/twe.c b/sys/dev/ic/twe.c
index ad17f0b33d3..a327dec2cd7 100644
--- a/sys/dev/ic/twe.c
+++ b/sys/dev/ic/twe.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: twe.c,v 1.52 2020/06/24 18:59:30 krw Exp $	*/
+/*	$OpenBSD: twe.c,v 1.53 2020/06/27 14:29:45 krw Exp $	*/
 
 /*
  * Copyright (c) 2000-2002 Michael Shalayeff.  All rights reserved.
@@ -401,7 +401,6 @@ twe_attach(sc)
 	sc->sc_link.adapter_buswidth = TWE_MAX_UNITS;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);
diff --git a/sys/dev/ic/uha.c b/sys/dev/ic/uha.c
index 315adeffe88..7ef900e8e4d 100644
--- a/sys/dev/ic/uha.c
+++ b/sys/dev/ic/uha.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: uha.c,v 1.30 2020/02/15 18:02:00 krw Exp $	*/
+/*	$OpenBSD: uha.c,v 1.31 2020/06/27 14:29:45 krw Exp $	*/
 /*	$NetBSD: uha.c,v 1.3 1996/10/13 01:37:29 christos Exp $	*/
 
 #undef UHADEBUG
@@ -129,7 +129,6 @@ uha_attach(sc)
 	sc->sc_link.openings = 2;
 	sc->sc_link.pool = &sc->sc_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	/*
diff --git a/sys/dev/ic/wd33c93.c b/sys/dev/ic/wd33c93.c
index 32d521d52ff..1a4237ed7b9 100644
--- a/sys/dev/ic/wd33c93.c
+++ b/sys/dev/ic/wd33c93.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: wd33c93.c,v 1.13 2020/06/24 22:03:41 cheloha Exp $	*/
+/*	$OpenBSD: wd33c93.c,v 1.14 2020/06/27 14:29:45 krw Exp $	*/
 /*	$NetBSD: wd33c93.c,v 1.24 2010/11/13 13:52:02 uebayasi Exp $	*/
 
 /*
@@ -210,7 +210,6 @@ wd33c93_attach(struct wd33c93_softc *sc, struct scsi_adapter *adapter)
 	sc->sc_link.luns = SBIC_NLUN;
 	sc->sc_link.pool = &wd33c93_iopool;
 
-	bzero(&saa, sizeof(saa));
 	saa.saa_sc_link = &sc->sc_link;
 
 	config_found(&sc->sc_dev, &saa, scsiprint);