diff options
| author |   bluhm <bluhm@openbsd.org> | 2017-05-04 15:19:01 +0000 |
|---|---|---|
| committer | bluhm <bluhm@openbsd.org> | 2017-05-04 15:19:01 +0000 |
| commit | 5a9f5148a90d7bf5e3dfb82159d93dc837536e83 (patch) | |
| tree | 6f3fbe10eb0a6885203e2a6d216884b77aa6bc63 /sys/dev/isa/gus.c | |
| parent | Introduce sstosa() for converting sockaddr_storage with a type safe (diff) | |
| download | wireguard-openbsd-5a9f5148a90d7bf5e3dfb82159d93dc837536e83.tar.xz wireguard-openbsd-5a9f5148a90d7bf5e3dfb82159d93dc837536e83.zip | |
Remove side effects from assignment. Fixes warning with cppcheck.
No binary change.
OK ratchov@
Diffstat (limited to 'sys/dev/isa/gus.c')
| -rw-r--r-- | sys/dev/isa/gus.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/dev/isa/gus.c b/sys/dev/isa/gus.c index 909c2103100..7058000254e 100644 --- a/sys/dev/isa/gus.c +++ b/sys/dev/isa/gus.c @@ -1,4 +1,4 @@ -/* $OpenBSD: gus.c,v 1.45 2016/09/19 06:46:44 ratchov Exp $ */ +/* $OpenBSD: gus.c,v 1.46 2017/05/04 15:19:01 bluhm Exp $ */ /* $NetBSD: gus.c,v 1.51 1998/01/25 23:48:06 mycroft Exp $ */ /*- @@ -858,7 +858,7 @@ gus_dmaout_dointr(struct gus_softc *sc) * flip to the next DMA buffer */ - sc->sc_dmabuf = ++sc->sc_dmabuf % sc->sc_nbufs; + sc->sc_dmabuf = (sc->sc_dmabuf + 1) % sc->sc_nbufs; /* * See comments below about DMA admission control strategy. * We can call the upper level here if we have an @@ -948,7 +948,7 @@ gus_voice_intr(struct gus_softc *sc) sc->sc_dev.dv_xname, sc->sc_bufcnt); gus_falsestops++; - sc->sc_playbuf = ++sc->sc_playbuf % sc->sc_nbufs; + sc->sc_playbuf = (sc->sc_playbuf + 1) % sc->sc_nbufs; gus_start_playing(sc, sc->sc_playbuf); } else if (sc->sc_bufcnt < 0) { panic("%s: negative bufcnt in stopped voice", @@ -1116,7 +1116,7 @@ gus_continue_playing(struct gus_softc *sc, int voice) * update playbuf to point to the buffer the hardware just started * playing */ - sc->sc_playbuf = ++sc->sc_playbuf % sc->sc_nbufs; + sc->sc_playbuf = (sc->sc_playbuf + 1) % sc->sc_nbufs; /* * account for buffer just finished |