diff options
| author |   stsp <stsp@openbsd.org> | 2020-07-20 08:09:30 +0000 |
|---|---|---|
| committer | stsp <stsp@openbsd.org> | 2020-07-20 08:09:30 +0000 |
| commit | 5c60d790042c0bf731339a08dc5704bb6c57e1fb (patch) | |
| tree | 9523f4e29e72171f2e74f0a2f235a31577ad274b /sys/dev/softraid.c | |
| parent | update a comment in iwn_ampdu_tx_done following previous SSN -> SEQ change (diff) | |
| download | wireguard-openbsd-5c60d790042c0bf731339a08dc5704bb6c57e1fb.tar.xz wireguard-openbsd-5c60d790042c0bf731339a08dc5704bb6c57e1fb.zip | |
Fix a logic bug in iwn(4) which meant that automatic rate control for
A-MPDU ran while a fixed Tx MCS was configured. The intention was of
course the inverse: Use automatic rate control if Tx MCS is not fixed.
There is a second bug which went unnoticed because of the above bug.
The value of 'seq' provided by firmware may be smaller than ba_winstart.
When this happened it triggered a KASSERT in ieee80211_output_ba_record_ack.
iwn_ampdu_rate_control() implicitly assumes that its 'seq' parameter equals
ba_winstart, so just pass that value directly.
tested by bket@, jmc@, and myself
ok mpi@
Diffstat (limited to 'sys/dev/softraid.c')
0 files changed, 0 insertions, 0 deletions