diff options
| author |   tedu <tedu@openbsd.org> | 2019-05-08 23:53:26 +0000 |
|---|---|---|
| committer | tedu <tedu@openbsd.org> | 2019-05-08 23:53:26 +0000 |
| commit | 5cb550263ac27de67bb0c7ef9d929ae7e71afa30 (patch) | |
| tree | 6da77fcd43ae5f58e608e6bfea4eadd745afda89 /sys/kern/kern_malloc.c | |
| parent | regen (diff) | |
| download | wireguard-openbsd-5cb550263ac27de67bb0c7ef9d929ae7e71afa30.tar.xz wireguard-openbsd-5cb550263ac27de67bb0c7ef9d929ae7e71afa30.zip | |
print a few warnings when calling free with a zero size.
let's see what falls out.
ok beck deraadt kettenis mpi
Diffstat (limited to 'sys/kern/kern_malloc.c')
| -rw-r--r-- | sys/kern/kern_malloc.c | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/sys/kern/kern_malloc.c b/sys/kern/kern_malloc.c index f39b17942b4..e25ba51ca18 100644 --- a/sys/kern/kern_malloc.c +++ b/sys/kern/kern_malloc.c @@ -1,4 +1,4 @@ -/* $OpenBSD: kern_malloc.c,v 1.136 2018/07/10 10:17:42 bluhm Exp $ */ +/* $OpenBSD: kern_malloc.c,v 1.137 2019/05/08 23:53:26 tedu Exp $ */ /* $NetBSD: kern_malloc.c,v 1.15.4.2 1996/06/13 17:10:56 cgd Exp $ */ /* @@ -45,6 +45,11 @@ #include <uvm/uvm_extern.h> +#if defined(DDB) +#include <machine/db_machdep.h> +#include <ddb/db_output.h> +#endif + static #ifndef SMALL_KERNEL __inline__ @@ -370,6 +375,7 @@ free(void *addr, int type, size_t freedsize) int s; #ifdef DIAGNOSTIC long alloc; + static int zerowarnings; #endif #ifdef KMEMSTATS struct kmemstats *ksp = &kmemstats[type]; @@ -392,6 +398,13 @@ free(void *addr, int type, size_t freedsize) if (size > MAXALLOCSAVE) size = kup->ku_pagecnt << PAGE_SHIFT; #ifdef DIAGNOSTIC + if (freedsize == 0 && zerowarnings < 5) { + zerowarnings++; + printf("free with zero size: (%d)\n", type); +#ifdef DDB + db_stack_dump(); +#endif + } if (freedsize != 0 && freedsize > size) panic("free: size too large %zu > %ld (%p) type %s", freedsize, size, addr, memname[type]); @@ -686,8 +699,6 @@ malloc_roundup(size_t sz) } #if defined(DDB) -#include <machine/db_machdep.h> -#include <ddb/db_output.h> void malloc_printit( |