diff options
author | 2015-10-13 09:11:48 +0000 | |
---|---|---|
committer | 2015-10-13 09:11:48 +0000 | |
commit | 9d4de16fe023193a84c3ca763e61653a383fd0cc (patch) | |
tree | 6dc64f6a47daa305bb3da58eb33eabecbfcd06fd /sys/netinet/ip_output.c | |
parent | ctype functions isxdigit() expect an unsigned char value; add missing casts (diff) | |
download | wireguard-openbsd-9d4de16fe023193a84c3ca763e61653a383fd0cc.tar.xz wireguard-openbsd-9d4de16fe023193a84c3ca763e61653a383fd0cc.zip |
Initialize va_filerev in vattr_null() to avoid leaking stack garbage;
problem pointed out by Martin Natano (natano (at) natano.net)
Also, stop chaining assignments (foo = bar = baz) in vattr_null().
The exact meaning of those depends on the order of the sizes-and-
signednesses of the lvalues, making them fragile: a statement here
mixed *six* types, but managed to get them in a safe order. Delete
a 20+ year old XXX comment that was almost certainly bemoaning a bug
from when they were in an unsafe order.
ok deraadt@ miod@
Diffstat (limited to 'sys/netinet/ip_output.c')
0 files changed, 0 insertions, 0 deletions