diff options
author | 2010-08-20 00:53:35 +0000 | |
---|---|---|
committer | 2010-08-20 00:53:35 +0000 | |
commit | cfd2bfaa08130b0b14381cd50886a5ed45570dcb (patch) | |
tree | f0eb22e5d4e567f53bbac852ee3d0e0b583c1527 /usr.bin/mandoc/man_validate.c | |
parent | Don't silently ignore errors if we cannot open the device. While I'm here (diff) | |
download | wireguard-openbsd-cfd2bfaa08130b0b14381cd50886a5ed45570dcb.tar.xz wireguard-openbsd-cfd2bfaa08130b0b14381cd50886a5ed45570dcb.zip |
Implement a simple, consistent user interface for error handling.
We now have sufficient practical experience to know what we want,
so this is intended to be final:
- provide -Wlevel (warning, error or fatal) to select what you care about
- provide -Wstop to stop after parsing a file with warnings you care about
- provide consistent exit status codes for those warnings you care about
- fully document what warnings, errors and fatal errors mean
- remove all other cruft from the user interface, less is more:
- remove all -f knobs along with the whole -f option
- remove the old -Werror because calling warnings "fatal" is silly
- always finish parsing each file, unless fatal errors prevent that
This commit also includes a couple of related simplifications behind
the scenes regarding error handling.
Feedback and OK kristaps@; Joerg Sonnenberger (NetBSD) and
Sascha Wildner (DragonFly BSD) agree with the general direction.
Diffstat (limited to 'usr.bin/mandoc/man_validate.c')
-rw-r--r-- | usr.bin/mandoc/man_validate.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/usr.bin/mandoc/man_validate.c b/usr.bin/mandoc/man_validate.c index cb7ab9b8dc3..873c625c549 100644 --- a/usr.bin/mandoc/man_validate.c +++ b/usr.bin/mandoc/man_validate.c @@ -1,4 +1,4 @@ -/* $Id: man_validate.c,v 1.28 2010/07/25 18:05:54 schwarze Exp $ */ +/* $Id: man_validate.c,v 1.29 2010/08/20 00:53:35 schwarze Exp $ */ /* * Copyright (c) 2008, 2009, 2010 Kristaps Dzonsons <kristaps@bsd.lv> * @@ -229,12 +229,8 @@ check_text(CHKARGS) if (c) { p += c - 1; pos += c - 1; - continue; - } - - c = man_pmsg(m, n->line, pos, MANDOCERR_BADESCAPE); - if ( ! (MAN_IGN_ESCAPE & m->pflags) && ! c) - return(c); + } else + man_pmsg(m, n->line, pos, MANDOCERR_BADESCAPE); } return(1); |