diff options
| author |   schwarze <schwarze@openbsd.org> | 2014-04-23 16:33:37 +0000 |
|---|---|---|
| committer | schwarze <schwarze@openbsd.org> | 2014-04-23 16:33:37 +0000 |
| commit | fd4216ccebcd41c2db6c4755836c1cd62a44738f (patch) | |
| tree | ba421b11874c5adc98dca13ca8201d40d0965651 /usr.bin/mandoc/mandocdb.c | |
| parent | tweak previous; sorry ingo, my review was pretty poor; (diff) | |
| download | wireguard-openbsd-fd4216ccebcd41c2db6c4755836c1cd62a44738f.tar.xz wireguard-openbsd-fd4216ccebcd41c2db6c4755836c1cd62a44738f.zip | |
improve SQL style: avoid "SELECT *", be explicit in what columns we want;
suggested by espie@.
Diffstat (limited to 'usr.bin/mandoc/mandocdb.c')
| -rw-r--r-- | usr.bin/mandoc/mandocdb.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/usr.bin/mandoc/mandocdb.c b/usr.bin/mandoc/mandocdb.c index 4a75494348c..ee75af0e0b8 100644 --- a/usr.bin/mandoc/mandocdb.c +++ b/usr.bin/mandoc/mandocdb.c @@ -1,4 +1,4 @@ -/* $Id: mandocdb.c,v 1.98 2014/04/20 16:44:44 schwarze Exp $ */ +/* $Id: mandocdb.c,v 1.99 2014/04/23 16:33:37 schwarze Exp $ */ /* * Copyright (c) 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2011, 2012, 2013, 2014 Ingo Schwarze <schwarze@openbsd.org> @@ -1279,7 +1279,8 @@ names_check(void) "AND mlinks.name == names.name" ")" ") JOIN (" - "SELECT * FROM mlinks GROUP BY pageid" + "SELECT sec, arch, name, pageid FROM mlinks " + "GROUP BY pageid" ") USING (pageid);", -1, &stmt, NULL); |