summaryrefslogtreecommitdiffstats
path: root/usr.bin/mandoc/tbl_data.c
diff options
context:
space:
mode:
authorschwarze <schwarze@openbsd.org>2015-01-30 17:31:20 +0000
committerschwarze <schwarze@openbsd.org>2015-01-30 17:31:20 +0000
commitcb1515965e22f6ee49d207ee6fbe66f94e9230ba (patch)
tree02f8cc31065f881e03a8b83aa7744c996bdb4d79 /usr.bin/mandoc/tbl_data.c
parentremove rndc (from bind) as well, ok deraadt (diff)
downloadwireguard-openbsd-cb1515965e22f6ee49d207ee6fbe66f94e9230ba.tar.xz
wireguard-openbsd-cb1515965e22f6ee49d207ee6fbe66f94e9230ba.zip
Delete the redundant tbl span flags, just inspect the actual data
where needed, which is less fragile. This fixes a subtle NULL pointer access to tp->tbl.cols: Due to a bug in the man(7) parser, the first span of a table can end up in a .TP head, in which case tblcalc() was never called. Found by jsg@ with afl.
Diffstat (limited to 'usr.bin/mandoc/tbl_data.c')
-rw-r--r--usr.bin/mandoc/tbl_data.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/usr.bin/mandoc/tbl_data.c b/usr.bin/mandoc/tbl_data.c
index 75ea87db76b..972868ff189 100644
--- a/usr.bin/mandoc/tbl_data.c
+++ b/usr.bin/mandoc/tbl_data.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: tbl_data.c,v 1.25 2015/01/30 04:08:37 schwarze Exp $ */
+/* $OpenBSD: tbl_data.c,v 1.26 2015/01/30 17:31:20 schwarze Exp $ */
/*
* Copyright (c) 2009, 2010, 2011 Kristaps Dzonsons <kristaps@bsd.lv>
* Copyright (c) 2011, 2015 Ingo Schwarze <schwarze@openbsd.org>
@@ -171,7 +171,6 @@ newspan(struct tbl_node *tbl, int line, struct tbl_row *rp)
if (dp->prev == NULL) {
tbl->first_span = dp;
tbl->current_span = NULL;
- dp->flags |= TBL_SPAN_FIRST;
} else
dp->prev->next = dp;
tbl->last_span = dp;