diff options
| author |   krw <krw@openbsd.org> | 2016-03-17 19:40:43 +0000 |
|---|---|---|
| committer | krw <krw@openbsd.org> | 2016-03-17 19:40:43 +0000 |
| commit | 534084640310a3b73784adb5e68a3695b1c4a21c (patch) | |
| tree | 6f4f33f996feb61f08988b759dea9f9a06a42f9a /usr.bin/sendbug/sendbug.c | |
| parent | Set mnt_data to NULL after freeing the file system specific mount point. (diff) | |
| download | wireguard-openbsd-534084640310a3b73784adb5e68a3695b1c4a21c.tar.xz wireguard-openbsd-534084640310a3b73784adb5e68a3695b1c4a21c.zip | |
Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.
Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.
Prompted by and probably ok deraadt@ millert@ kettenis@
Definitely ok mestre@ ratchov@
Diffstat (limited to 'usr.bin/sendbug/sendbug.c')
| -rw-r--r-- | usr.bin/sendbug/sendbug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr.bin/sendbug/sendbug.c b/usr.bin/sendbug/sendbug.c index dc39073328e..bba83035ae1 100644 --- a/usr.bin/sendbug/sendbug.c +++ b/usr.bin/sendbug/sendbug.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sendbug.c,v 1.73 2015/10/26 13:12:10 deraadt Exp $ */ +/* $OpenBSD: sendbug.c,v 1.74 2016/03/17 19:40:43 krw Exp $ */ /* * Written by Ray Lai <ray@cyth.net>. @@ -337,7 +337,7 @@ sendmail(const char *pathname) } close(filedes[0]); execl(_PATH_SENDMAIL, "sendmail", - "-oi", "-t", (void *)NULL); + "-oi", "-t", (char *)NULL); warn("sendmail error: unsent report in %s", pathname); return (-1); |