diff options
| author |   schwarze <schwarze@openbsd.org> | 2014-07-25 21:05:38 +0000 |
|---|---|---|
| committer | schwarze <schwarze@openbsd.org> | 2014-07-25 21:05:38 +0000 |
| commit | 5e8c02716c0b251707eff901ba9803c3507861b1 (patch) | |
| tree | 317b1a9da6e6648be81516f2c06b241c794500ad /usr.bin/ssh/ssh-agent.c | |
| parent | Don't leak docroot in the error message if the default index file is missing. (diff) | |
| download | wireguard-openbsd-5e8c02716c0b251707eff901ba9803c3507861b1.tar.xz wireguard-openbsd-5e8c02716c0b251707eff901ba9803c3507861b1.zip | |
Choosing the right encoding is a tricky business...
Printing query strings for URIs *always* needs URI-encoding, and when
embedding the URI into an HTML document, it needs replacement of
the "&" separators by "&" *in addition to that*, not instead.
Delete the function html_primtquery(), it was completely wrong.
You can see the badness by entering "mandoc &sec=2" into the query input
box before this patch and click "Submit". You come to the right page at
first (...man.cgi?query=mandoc+%26sec%3D2&apropos=0&sec=0&...), but now
the link to mandoc(1) is wrong: ...mandoc.1?query=mandoc &sec=2&...
Clicking on that, the "&sec=2" disappears from the query input box and
suddenly you have the first dropdown set to "2 - System Calls". Oops.
Diffstat (limited to 'usr.bin/ssh/ssh-agent.c')
0 files changed, 0 insertions, 0 deletions